docs: correct the stale claims in the README - #7
Open
Siddhesh2377 wants to merge 1 commit into
Open
Conversation
|
Important Review available on request
Reviews should be triggered manually for repositories with fewer than 10 stars. Select Trigger review above or comment ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README had drifted from the app. Every claim below was checked against the code before changing it. Net 357 lines deleted, 194 added.
What was wrong
RunAnywhere.processImageStreamdoes not exist. The app callsRunAnywhere.vlm.generateStream(src/services/VLMService.ts:51). That verb survives only in stale SDK docs.LlamaCpp.addModel,Onnx.addModel,ModelCategory.speechRecognition. Replaced with the realRunAnywhere.models.registershape plus thearchiveUrlandfiles[]variants the app uses.android/build.gradlesets 28.0.13004108.WRITE_EXTERNAL_STORAGEandREAD_EXTERNAL_STORAGE. The manifest hasINTERNETandRECORD_AUDIO.VisionScreen,ToolCallingScreen,VLMService.tsandutils/.Sections deleted because they describe things that do not exist
rac_defaults_generated.htroubleshooting section. That defect was specific to@runanywhere/core@0.20.18and was fixed by4dfccf763, which ships in v0.20.19, the version this repo pins. The section told readers to build iOS only and not to use this repo's own pinned version.patches/directory, nopatch-packagedependency and nopostinstallscript.podspecPathrationale forautomaticPodsInstallation: false. No@runanywherepackage at 0.20.19 usespodspecPath. The manualpod installinstruction stays, with an accurate reason.CONTRIBUTING.mdlink, a Discord link, an/apidocs link, and an Acknowledgments section crediting react-native-reanimated, which is not a dependency.What was added
The Hermes manual-iterator rule with a real example from
ChatScreen.tsx, since Hermes does not supportfor await...ofover NitroModules async iterables. That iOS builds with the new architecture off while Android builds with it on, and the resultingreact-native-screensmetro shim.yarn typecheckas the verification gate. The actual eight-entry model catalog.The absolute "no internet required" privacy claim is softened: the weather tool hits wttr.in and the vision screen fetches remote image URLs.
Two things that should be fixed before this repo is usable from a clean clone
yarn.lockresolves every@runanywhere/*at 0.20.18 whilepackage.jsonpins 0.20.19. The bump commit did not regenerate the lock.yarn install --immutable, the CI default, fails outright, and 0.20.18 is the exact release with the Androidrac_defaults_generated.hbuild break, so anyone installing from the lock as-is gets an unbuildable Android target.yarn testcannot work. The script runsjest, butjestis not indevDependenciesand does not appear inyarn.lock, and there is nojest.config.js. It is left undocumented here rather than documented as a working command.Other things noticed, not changed
ios/RunAnywhereStarter/Info.plistsetsRCTNewArchEnabledtrue while the Podfile passesnew_arch_enabled => falseand stripsRCT_NEW_ARCH_ENABLEDfrom every pod target. The Podfile wins; the plist should agree.react-native.config.jsandsrc/App.tsxcarry the stalepodspecPathrationale in comments.react-native-live-audio-streamandreact-native-soundare declared and imported nowhere.ModelService.tsxandchatSampleTools.tsreferencerunanywhere-sdks/examples/react-native/..., a pre-0.20.17 path.android/build.gradleprobes/opt/homebrew/binfor node first, which makes the Android build macOS-specific in a way nothing documents.LICENSEfile, though the README claims MIT. The claim was kept; the file should be added.Documentation only. No source changes.