Skip to content

fix(terminal): disclose missing scrollback after resume - #544

Open
RonenMars wants to merge 4 commits into
mainfrom
fix/resumed-terminal-scrollback-disclosure
Open

fix(terminal): disclose missing scrollback after resume#544
RonenMars wants to merge 4 commits into
mainfrom
fix/resumed-terminal-scrollback-disclosure

Conversation

@RonenMars

Copy link
Copy Markdown
Owner

Summary

  • Resumed sessions lose prior PTY scrollback by design (in-memory ring buffer dies with the process).
  • Terminal mode now shows a top-of-scrollback notice explaining that, with a link to the durable conversation history.
  • Fresh sessions are unchanged; live PTY output is still the only terminal bytes.

Test plan

  • Resume a session, open terminal mode — notice appears at top of scrollback
  • Tap “View the conversation history →” — navigates to /conversation/<id>
  • Start a fresh (non-resumed) session — notice does not appear
  • After resume, live terminal output still streams below the notice
  • npx jest --ci --runInBand --testPathPattern "Terminal(Output|View)"

PTY ring buffers die with the process, so resumed sessions start empty. Show an explicit link to conversation history instead of a silent blank scrollback.
Replace food/materials-sense translations (גולמי / сырой / الخام) with uppercase RAW so the mode label stays recognizable across locales.
Use uppercase RAW as the shared mode name everywhere the UI refers to unfiltered terminal output, matching the terminal banner copy.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant