fix(ios): patch expo-modules-jsi Swift 6 abs() overload ambiguity - #417
Closed
RonenMars wants to merge 1 commit into
Closed
fix(ios): patch expo-modules-jsi Swift 6 abs() overload ambiguity#417RonenMars wants to merge 1 commit into
RonenMars wants to merge 1 commit into
Conversation
Xcode 26.3's Swift 6 compiler fails on abs(milliseconds) in expo-modules-jsi's Date decoding with "type of expression is ambiguous without a type annotation", breaking the Ship iOS job. Expo's real fix (Xcode 26.4) isn't on GitHub's macos-15 runner yet, so patch-package disambiguates the call as a stopgap.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
abs(milliseconds)in expo-modules-jsi's Date decoding with "type of expression is ambiguous without a type annotation", breaking the Ship iOS job (run 30127420057).Swift.abs(milliseconds). Registeredpatches/as a CI-significant path so future patch-only changes aren't mis-tagged[skip-ci].DEVELOPER_DIRnoting to bump to Xcode 26.4 and drop the patch once the runner image has it.Test plan
npm installapplies the patch viapostinstall(verified locally)