Fix nav2_smac_planner robin_hood Windows build - #92
Merged
traversaro merged 1 commit intoJul 21, 2026
Merged
Conversation
This was referenced Jul 20, 2026
Contributor
Author
|
This probe did what we needed:
The cause appears to be the |
Keep the Windows rebuild for nav2_smac_planner, but include the actual MSVC fix identified by the probe: move the NOLINT suppression in the vendored robin_hood.h macro body off the macro-continuation backslash. This preserves robin_hood::unordered_node_map on Windows while avoiding the MSVC syntax errors seen when compiling a_star.cpp. The build number bump remains to force a rebuild.
Tobias-Fischer
force-pushed
the
codex/nav2-smac-planner-robinhood-probe
branch
from
July 20, 2026 22:37
c6509db to
742ed39
Compare
Contributor
Author
|
Can we merge this @traversaro or could there be ABI issues? |
Member
The header is installed, by the library is actually a plugin that is loaded at runtime, so I think it is actually safe to merge. |
traversaro
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the kilted
nav2_smac_plannerWindows patch after the upstream Navigation2 review feedback on ros-navigation/navigation2#6276.The first CI probe showed that removing RoboStack's
std::unordered_mapfallback exposed the actual Windows failure: MSVC could not parse the vendoredrobin_hood.hmacro because a// NOLINTcomment followed a macro-continuation backslash.This PR now keeps
robin_hood::unordered_node_mapon Windows and applies the same macro-continuation fix proposed upstream, while keeping thenav2_smac_plannerbuild-number bump so CI rebuilds the package.Validation:
release/kilted/nav2_smac_planner/1.4.2-1.