Dev 123965 general improvements fixes#97
Merged
tomerparizer merged 10 commits intoJun 26, 2026
Merged
Conversation
…Riskified/php_sdk into DEV-123965_general-improvements_fixes
…Riskified/php_sdk into DEV-123965_general-improvements_fixes # Conflicts: # src/Riskified/DecisionNotification/Model/Notification.php # src/Riskified/polyfill.php
…Riskified/php_sdk into DEV-123965_general-improvements_fixes
…Riskified/php_sdk into DEV-123965_general-improvements_fixes
DavidRibeiroRiskified
approved these changes
Jun 26, 2026
tomerparizer
merged commit 21c33b6
into
DEV-123965_general-improvements
1 of 2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summery
Follow-up cleanup on top DEV-123965_general-improvements of that gets the codebase to a green composer check (lint + static analysis) and a fully passing test suite. This is a code-quality / standards pass — no changes to runtime behavior or the public API.
what changed?
composer analyseto run code analysis and fixed findingscomposer lintandcomposer fixto run lint and fixed findingsNote
these changes are just those fixes.. no code shuold have change
Relates to #98