Upgrade to TypeScript 7 (native compiler)#1149
Conversation
Move the workspace to typescript@7.0.1-rc (the native Go compiler) across the
bun catalog and all packages that pin typescript directly.
TS7 removes the classic require("typescript") JS compiler API, which required
working around two consumers:
- Patch tsup so its eager typescript require tolerates the missing module (it
loads typescript at module init even when dts is disabled).
- Rewrite the sdk tool-output-contract test helper to type-check synthesized
snippets by invoking the native tsgo binary instead of the in-process
compiler API.
- Move desktop-settings declaration emit from rollup-plugin-dts (classic API)
to native tsc --emitDeclarationOnly.
Drop the effect-language-service patch from the prepare hook (it patches the
classic compiler and is incompatible with TS7); it remains an inert tsconfig
plugin entry.
The native compiler enforces rootDir against cross-package react source imports
that the previous toolchain tolerated, so widen rootDir in the app, cloud, and
local tsconfigs (all noEmit typecheck targets that build via Vite).
Verified: install, typecheck (41/41), build:packages, format, lint, and the
affected contract consumer tests all pass.
Cloudflare preview
Sign-in is Cloudflare Access (one-time PIN to an allowed email). The preview has its own database and encryption key; it is destroyed when this PR closes. |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-cloud | 212632b | Jun 26 2026, 04:12 PM |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-marketing | 212632b | Commit Preview URL Branch Preview URL |
Jun 26 2026, 04:12 PM |
@executor-js/cli
@executor-js/config
@executor-js/execution
@executor-js/sdk
@executor-js/codemode-core
@executor-js/runtime-quickjs
@executor-js/plugin-file-secrets
@executor-js/plugin-graphql
@executor-js/plugin-keychain
@executor-js/plugin-mcp
@executor-js/plugin-onepassword
@executor-js/plugin-openapi
executor
commit: |
Greptile SummaryThis PR upgrades the entire workspace from TypeScript 5.x to
Confidence Score: 3/5The tsconfig, lockfile, and patch changes are straightforward and well-motivated; the tool-output-contract rewrite introduces a spawn-error blind spot that can mask type-check failures entirely. The packages/core/sdk/src/testing/tool-output-contract.ts and packages/plugins/desktop-settings/package.json deserve a second look before merging. Important Files Changed
Sequence Diagram%%{init: {'theme': 'neutral'}}%%
sequenceDiagram
participant Test as Test Suite
participant Helper as tool-output-contract.ts
participant FS as tmp filesystem
participant tsgo as tsgo (native binary)
Test->>Helper: typeCheckOutputTypeScript(contract, output, opts)
Helper->>Helper: resolveTsgoShim() → path to tsgo.js
Helper->>FS: mkdtempSync() → create temp dir
Helper->>FS: writeFileSync(fileName, synthesized source)
Helper->>tsgo: spawnSync(node, [tsgo.js, --noEmit, ...flags, fileName])
alt spawn succeeds
tsgo-->>Helper: stdout/stderr with TS diagnostics
Helper->>Helper: filter lines matching /: error TS\d+:/
Helper-->>Test: "string[] of error lines (empty = pass)"
else spawn fails (ENOENT / signal / OOM)
tsgo-->>Helper: "result.error set, stdout=null, stderr=null"
Helper->>Helper: ?? "" guards produce empty strings
Helper-->>Test: [] ← falsely indicates clean type-check
end
Helper->>FS: rmSync(dir, recursive+force)
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
sequenceDiagram
participant Test as Test Suite
participant Helper as tool-output-contract.ts
participant FS as tmp filesystem
participant tsgo as tsgo (native binary)
Test->>Helper: typeCheckOutputTypeScript(contract, output, opts)
Helper->>Helper: resolveTsgoShim() → path to tsgo.js
Helper->>FS: mkdtempSync() → create temp dir
Helper->>FS: writeFileSync(fileName, synthesized source)
Helper->>tsgo: spawnSync(node, [tsgo.js, --noEmit, ...flags, fileName])
alt spawn succeeds
tsgo-->>Helper: stdout/stderr with TS diagnostics
Helper->>Helper: filter lines matching /: error TS\d+:/
Helper-->>Test: "string[] of error lines (empty = pass)"
else spawn fails (ENOENT / signal / OOM)
tsgo-->>Helper: "result.error set, stdout=null, stderr=null"
Helper->>Helper: ?? "" guards produce empty strings
Helper-->>Test: [] ← falsely indicates clean type-check
end
Helper->>FS: rmSync(dir, recursive+force)
Reviews (1): Last reviewed commit: "Upgrade to TypeScript 7 (native compiler..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| const result = spawnSync( | ||
| process.execPath, | ||
| [ | ||
| resolveTsgoShim(), | ||
| "--noEmit", | ||
| "--strict", | ||
| "--skipLibCheck", | ||
| "--target", | ||
| "es2022", | ||
| "--module", | ||
| "esnext", | ||
| "--pretty", | ||
| "false", | ||
| fileName, | ||
| ], | ||
| { cwd: dir, encoding: "utf8" }, | ||
| ); | ||
| return `${result.stdout ?? ""}\n${result.stderr ?? ""}` | ||
| .split("\n") | ||
| .map((line) => line.trim()) | ||
| .filter((line) => ERROR_LINE.test(line)); |
There was a problem hiding this comment.
spawnSync sets result.error when the process cannot be started (e.g., ENOENT from a missing tsgo binary, an OOM kill, or a signal termination) and leaves result.stdout / result.stderr as null. The ?? "" guards produce empty strings, the ERROR_LINE filter matches nothing, and the function returns [] — indistinguishable from a clean type-check. Any test relying on this helper will silently pass without the compiler ever running. A result.error (or a null result.status) check is needed to surface the failure.
| }, | ||
| "scripts": { | ||
| "build": "tsup", | ||
| "build": "tsup && (tsc --declaration --emitDeclarationOnly --outDir dist --rootDir src || true)", |
There was a problem hiding this comment.
|| true silences all tsc declaration-emit errors
The || true makes the build script always succeed regardless of why tsc exits non-zero. If tsc encounters real type errors (not just the rootDir/TS6059 issue mentioned in the PR), the build completes silently with potentially incomplete or incorrect .d.ts files. A targeted exit-code filter would let the intended TS6059 class through while still propagating other failures.
| "build": "tsup && (tsc --declaration --emitDeclarationOnly --outDir dist --rootDir src || true)", | |
| "build": "tsup && (tsc --declaration --emitDeclarationOnly --outDir dist --rootDir src 2>&1 | grep -v 'error TS6059' || true)", |
1 participant
Moves the workspace to
typescript@7.0.1-rc, the native (Go) compiler, across the bun catalog and every package that pins typescript directly.Why it is not a one-line bump
TS7 removes the classic
require("typescript")JS compiler API (the package no longer exposes amain; it exports only./package.jsonand./unstable/*). A few consumers depended on that API:dts: false, so it now throwsERR_PACKAGE_PATH_NOT_EXPORTED. Added a patch that makes its typescript require tolerant.tool-output-contracttest helper used the in-process virtual-host compiler API. Rewritten to type-check synthesized snippets by shelling out to the nativetsgobinary.tsc --emitDeclarationOnly.The
effect-language-servicepatch is dropped from thepreparehook (it patches the classic compiler and is incompatible with TS7); it stays as an inert tsconfig plugin entry.rootDir change
The native compiler enforces
rootDiragainst cross-package React source imports that the previous toolchain tolerated (TS6059). WidenedrootDirin theapp,cloud, andlocaltsconfigs. These are all--noEmittypecheck targets that build via Vite, so the change only affects the diagnostic, not emit.Verification
bun install(lockfile consistent, prepare hook runs)bun run typecheck(41/41)bun run build:packagesbun run format:checkbun run lint(0/0)