Auto-connect stdio MCP servers; store env as connection secrets#1129
Draft
RhysSullivan wants to merge 1 commit into
Draft
Auto-connect stdio MCP servers; store env as connection secrets#1129RhysSullivan wants to merge 1 commit into
RhysSullivan wants to merge 1 commit into
Conversation
Adding a stdio MCP server registered an integration but no connection, so the v1.5 per-connection tool model produced zero tools on a fresh install. Auto-create the default connection on add (no-auth, or one-shot env values), declare secret env vars as a stdio_env auth method whose values live on the connection's secret store, add a boot-time reconcile for pre-existing stdio integrations, and give the add form a TagInput for declaring env var names.
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-marketing | 653c2c7 | Commit Preview URL Branch Preview URL |
Jun 25 2026, 09:08 AM |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-cloud | 653c2c7 | Jun 25 2026, 09:09 AM |
Contributor
Cloudflare preview
Sign-in is Cloudflare Access (one-time PIN to an allowed email). The preview has its own database and encryption key; it is destroyed when this PR closes. |
@executor-js/cli
@executor-js/config
@executor-js/execution
@executor-js/sdk
@executor-js/codemode-core
@executor-js/runtime-quickjs
@executor-js/plugin-file-secrets
@executor-js/plugin-graphql
@executor-js/plugin-keychain
@executor-js/plugin-mcp
@executor-js/plugin-onepassword
@executor-js/plugin-openapi
executor
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On a fresh install, adding a STDIO MCP server detected zero tools.
mcp.addServeronly registered an integration. Since the v1.5 integrations/connections split, tools are produced per connection (at connection create), and a stdio add never created one, so the integration landed with zero connections and therefore zero tools. The console could not recover it either: stdio declared no auth methods, so the "Add connection" affordance was disabled.Separately, a stdio server's
env(often API keys/tokens) was kept in the integration config blob in plaintext rather than the secret store.Change
stdio_envauth method (names only); their values live in the connection's secret store and are injected into the subprocess at launch. A newenvplacement carrier carries this through the catalog descriptor, the wire schema, and the console.Testing
e2e/local/stdio-mcp.test.ts) on the single-user app (the only surface with stdio enabled), booted on a throwaway data dir (the fresh-install condition). It covers both paths: one-shot values, and declare-then-connect. It asserts the integration registers, the connection is created, the tools are detected (including an env-gated tool, proving the secret reaches the subprocess), and the secret value is absent from the integration config.typecheck,lint,format:checkclean; plugin and console unit suites pass.