feat: add getGameLeaderboards() function#133
Merged
wescopeland merged 4 commits intoJul 13, 2026
Merged
Conversation
wescopeland
reviewed
Feb 4, 2026
Confidence Score: 5/5This looks safe to merge after normalizing numeric totals.
src/leaderboard/getGameLeaderboards.ts Reviews (1): Last reviewed commit: "Merge branch 'main' into feat/leaderboar..." | Re-trigger Greptile |
Comment on lines
+87
to
+90
| return serializeProperties(rawResponse, { | ||
| shouldCastToNumbers: ["ID", "Score"], | ||
| shouldMapToBooleans: ["RankAsc"], | ||
| }); |
There was a problem hiding this comment.
Numeric totals bypass coercion
When the API returns string Count or Total values, callers receive strings despite the public numeric contract.
Suggested change
| return serializeProperties(rawResponse, { | |
| shouldCastToNumbers: ["ID", "Score"], | |
| shouldMapToBooleans: ["RankAsc"], | |
| }); | |
| return serializeProperties(rawResponse, { | |
| shouldCastToNumbers: ["Count", "Total", "ID", "Score"], | |
| shouldMapToBooleans: ["RankAsc"], | |
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
getGameLeaderboardsfunction to the library to match what is available in the Game Leaderboards documentation.pnpm verifyhas passed, and the required tests are included in this PR.PR for documentation update: RetroAchievements/api-docs#97
Resolves #115