fix: display flat for RHF peer-review bounty notifications#749
fix: display flat for RHF peer-review bounty notifications#749jeevan6996 wants to merge 7 commits into
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
|
@jeevan6996 is attempting to deploy a commit to the ResearchHub Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit dfde721. Configure here.
|
Implemented the Cursor feedback and pushed an update to keep bounty messaging consistent: is now applied regardless of , so the badge/value no longer diverges from the notification message in peer-review bounty cases. |
|
Correction: implemented the Cursor feedback and pushed an update to keep bounty messaging consistent. The bountyUsdOverride value is now applied regardless of showUSD, so the badge/value no longer diverges from the notification message in peer-review bounty cases. |
|
You have used all of your free Bugbot PR reviews. To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial. |
|
Quick follow-up: Sonar checks are green; the remaining blocker is Vercel authorization for this repo/team integration. If a team member can authorize the deployment integration, this PR should be unblocked for normal review. |
|
|
Quick status check from my side: code changes are complete, and the remaining failure is Vercel. If a maintainer can help with deployment authorization/trigger, I can handle any follow-up changes immediately. |
|
Addressed the remaining Cursor finding in commit 3034936: the flat USD override now only applies to BOUNTY_FOR_YOU review notifications when the notification extra identifies the bounty creator as the configured ResearchHub Foundation user. This avoids applying the Foundation display to non-Foundation review bounties. Local verification: formatted the touched files and ran git diff --check. Full npm type-check could not be completed locally because npm ci is blocked by the private Tiptap Pro registry credentials (403 from registry.tiptap.dev). The current PR check failure remains Vercel authorization required for the ResearchHub team deployment. |
|




Summary
Adjusts bounty notification display so RHF-sponsored peer review bounty prompts show a flat
$150 USDamount instead of derived variable amounts.Closes ResearchHub/issues#342
Changes
BOUNTY_FOR_YOU+REVIEW)FOUNDATION_BOUNTY_FLAT_USDFiles
components/Notification/lib/formatNotification.tscomponents/Notification/NotificationItem.tsxTesting
libsimdjson.31.dylib), so CI validation is required.Note
Low Risk
Small, UI-only formatting change scoped to a single notification type; risk is limited to incorrect amount/currency display for affected notifications.
Overview
Updates
BOUNTY_FOR_YOUnotifications withbounty_type=REVIEWto display a fixedFOUNDATION_BOUNTY_FLAT_USDamount instead of deriving USD from the RSC amount/exchange rate.Adds
getBountyForYouUsdOverrideinformatNotification.tsand applies it both to the notification message text and theCurrencyBadgeinNotificationItem(forcing USD + skipping conversion) so the badge and message remain consistent.Reviewed by Cursor Bugbot for commit dfde721. Bugbot is set up for automated code reviews on this repo. Configure here.