fix: stop every /request/<id> URL returning HTTP 500

[rodrigopavezi]

Every /request/<id> URL on scan.request.network returns HTTP 500. This fixes it. Bottom of a 3-PR stack; independently mergeable.

Came out of an SEO audit (Linear REQ-285) that listed 132 request URLs returning 5XX. It is not 132 broken pages — it is one bug, and the set is unbounded: a request created minutes ago 500s just the same.

Root cause

html2pdf.js 0.10.2 — the version package-lock.json pins — invokes its UMD wrapper with a bare self identifier, evaluated before the inner require()s and with no typeof self !== "undefined" guard. Node has no global self, so importing it server-side throws. It was imported at module scope in use-export-pdf.tsx, whose only importer is request/[id]/page.tsx — which is exactly why that one route 500ed while every other returned 200.

Reproduced locally before the fix:

ReferenceError: self is not defined
    at 11378 (.next/server/app/request/[id]/page.js)
    at Object.t [as require] (.next/server/webpack-runtime.js)

The import now happens inside the export handler, so it only evaluates in a browser.

Impact worth stating precisely: Next.js bails out to client rendering after the SSR throw, so a real browser renders the page fine — users clicking through from the homepage were unaffected. Crawlers, shared links, hard refreshes and anything status-code-sensitive got a 500 with no content.

Side benefit: the route's page bundle drops 196 kB → 22.8 kB and first-load JS 1.02 MB → 851 kB, since html2pdf no longer ships eagerly.

Why CI never caught this

next build compiles the route but never requests it — page.tsx has no generateStaticParams, so the build marks it ƒ (Dynamic) server-rendered on demand. npm run check is biome check --write, formatting only, and --write means it cannot fail on anything auto-fixable. There are no tests in the repo. PR #117 adds the request-time smoke check that would have caught it.

Also in this PR

All found while tracing the above:

• Error boundaries. There were none — no app/error.tsx, no global-error.tsx, no root not-found.tsx (app/not-found/page.tsx is an ordinary route, not the convention file). Any render-time throw escaped to a raw 500. Added all three; neither leaks an error message or stack.
• A missing request reported 200. The page called redirect("/not-found") — a 307 to a page that itself returns 200, i.e. a soft 404 telling crawlers a nonexistent request exists. Now notFound().
• "Failed" was indistinguishable from "not found." The page read only isLoading, never error, so a backend failure rendered as "not found". Now gates on the query's status: pending → skeleton, error → error state, success-and-empty → notFound(). isLoading was doubly wrong here — with react-query v5 it is isPending && isFetching, and no fetch happens during SSR, so it is false on the server and the skeleton guard never fired there.
• Error states in the three "Recent …" widgets, which ignored the status their hooks already return and rendered "No data" on failure. This is live today: the payments subgraph returns no allocations, so the home page currently reports empty rather than broken.
• Two crashers guarded. The fully-unguarded extensionsData[0].parameters path in request-table.tsx throws while evaluating arguments, and therefore outside the try/catch inside calculateShortPaymentReference — the likely cause of Request Scan Requests page crashes due to "Error calculating short payment reference" #89. And BigInt(Number(gasUsed) * Number(gasPrice)) in payment-table.tsx, where a missing field makes BigInt(NaN) throw a RangeError; it now multiplies in BigInt, which also avoids losing precision above Number.MAX_SAFE_INTEGER.
• Dropped @react-pdf/renderer, imported nowhere. The lockfile is regenerated to match — worth noting because npm ci fails on a package.json/lockfile mismatch, so CI would have broken on its first job otherwise.

Likely also closes #72 (an unindexed request showing as "404") now that error and not-found are distinct states.

Verification

npm ci → npm run check → npm run build, then a real server:

Route	Before	After
/request/<id>	500	200
/, /requests, /payments	200	200
unmatched route	—	404
self is not defined in log	present	zero

Known gap, fixed in #118

The page still fetches on the client, so the served HTML is a skeleton with no request data, and a nonexistent id returns 200 rather than 404. Both need a server-side fetch — that is #118.

[rodrigopavezi]

• feat: server-render the request page so crawlers get the request #118
• fix: one dead subgraph no longer wipes out all payment data #117
• fix: stop every /request/<id> URL returning HTTP 500 #116 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[greptile-apps]

Greptile Summary

Fixes request-page server rendering and improves failure handling across the application.

• Defers loading html2pdf.js until the browser invokes PDF export.
• Adds App Router error and not-found boundaries and distinguishes request loading, error, and empty states.
• Surfaces query failures in recent-data widgets.
• Safely handles missing payment-reference and gas-fee fields.
• Removes the unused @react-pdf/renderer dependency.

Confidence Score: 5/5

The PR appears safe to merge, with no concrete blocking or independently actionable issues identified in the changed code.

The browser-only PDF dependency is deferred from server evaluation, the revised request-state branches remain reachable, malformed table data is guarded, and the new error boundaries do not depend on the normal provider tree.

Important Files Changed

Filename	Overview
src/lib/hooks/use-export-pdf.tsx	Moves the browser-only html2pdf import into the user-triggered export path, preventing server-side module evaluation.
src/app/request/[id]/page.tsx	Uses explicit request query states, invokes the not-found boundary for empty results, and guards malformed transaction data.
src/app/error.tsx	Adds a recoverable route-level error boundary without exposing exception details.
src/app/global-error.tsx	Adds a valid root-level fallback document with retry behavior.
src/app/not-found.tsx	Adds the shared App Router not-found presentation.
src/components/payment-table.tsx	Computes network fees with exact bigint arithmetic and safely handles absent or malformed gas values.
src/components/request-table.tsx	Adds optional access throughout payment-reference extraction to prevent malformed rows from crashing rendering.
src/components/recent-payment-table.tsx	Distinguishes payment-query errors from legitimate empty results.
src/components/recent-request-table.tsx	Distinguishes request-query errors from legitimate empty results.
src/components/recent-srf-deployments-table.tsx	Distinguishes deployment-query errors from legitimate empty results.
package.json	Removes the unused React PDF renderer dependency, with corresponding lockfile cleanup.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Open request route] --> B{Request query status}
  B -->|Pending| C[Render skeleton]
  B -->|Error| D[Render error state]
  B -->|Success without request| E[Invoke notFound]
  B -->|Success with request| F[Render request details]
  F --> G{Export PDF clicked?}
  G -->|Yes| H[Dynamically import html2pdf.js]
  H --> I[Generate and download PDF]

Loading

_{Reviews (1): Last reviewed commit: "fix: stop every /request/<id> URL return..." | Re-trigger Greptile}

[bassgeta]

Looks good, error handling is nice even though it's a dead repo 😅

[rodrigopavezi]

Merge activity

• Jul 29, 2:11 PM UTC: A user started a stack merge that includes this pull request via Graphite.
• Jul 29, 2:12 PM UTC: @rodrigopavezi merged this pull request with Graphite.