-
Notifications
You must be signed in to change notification settings - Fork 0
Accept bare int for int32 config fields in parser #265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| name = "LogicalQueryProtocol" | ||
| uuid = "a92373ee-6cc4-4662-ae66-0c99a03ebae1" | ||
| version = "0.5.5" | ||
| version = "0.5.6" | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please keep the version bumps to separate PRs |
||
| authors = ["RelationalAI"] | ||
|
|
||
| [deps] | ||
|
|
||
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that the S-expression syntax is meant for human readability, not necessarily writing convenience, I'd argue that the thing to do here for now is to assert that it's an
int32_value.Because if we allow promotion, we should do it generally, meaning anywhere that I write
1i32today, I can just write1instead. But I'm not sure that convenience is worth having an implicit behaviour. The real problem here is the silent failure, not that we're strict.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense. I will create another PR for that and close this one.