fix: prevent external link icon from wrapping#1682
Open
Dugowitch wants to merge 1 commit into
Open
Conversation
HMS-10988 This commit fixes the issue that when the text is just the right length the external link icon would wrap onto a new line and be there alone. The added zero-width joiner will ensure no wrapping just before it and the span with no-wrap class glues the joiner with the icon, therefore the text can wrap but the icon will always have at least one word with it on the same line.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1682 +/- ##
=======================================
Coverage 77.27% 77.27%
=======================================
Files 103 103
Lines 3287 3287
Branches 740 741 +1
=======================================
Hits 2540 2540
Misses 668 668
Partials 79 79 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Associated Jira ticket: HMS-10988
This commit fixes the issue that when the text is just the right length the external link icon would wrap onto a new line and be there alone. The added zero-width joiner will ensure no wrapping just before it and the span with no-wrap class glues the joiner with the icon, therefore the text can wrap but the icon will always have at least one word with it on the same line.
How to test the PR
Please include steps to test your PR.
Before the change
After the change
Checklist: