feat: add aggregator service with Kafka consumer skeleton #2263
+204
−3
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| package aggregator | ||
|
|
||
| import ( | ||
| "app/base" | ||
| "app/base/core" | ||
| "app/base/mqueue" | ||
| "app/base/utils" | ||
| "sync" | ||
|
|
||
| "github.com/gin-gonic/gin" | ||
| ) | ||
|
|
||
| var ( | ||
| advisoryUpdateTopic string | ||
| enableNotifications bool | ||
| consumerCount int | ||
| ) | ||
|
|
||
| func readPodConfig() { | ||
| consumerCount = utils.PodConfig.GetInt("consumer_count", 1) | ||
| enableNotifications = utils.PodConfig.GetBool("instant_notifications", false) | ||
| } | ||
|
|
||
| func configure() { | ||
| advisoryUpdateTopic = utils.FailIfEmpty(utils.CoreCfg.AdvisoryUpdateTopic, "ADVISORY_UPDATE_TOPIC") | ||
| configureNotifications() | ||
| } | ||
|
|
||
| func runServer() { | ||
| app := gin.New() | ||
| core.InitProbes(app) | ||
| go base.TryExposeOnMetricsPort(app) | ||
|
|
||
| err := utils.RunServer(base.Context, app, utils.CoreCfg.PublicPort) | ||
| if err != nil { | ||
| utils.LogError("err", err.Error()) | ||
| panic(err) | ||
| } | ||
| } | ||
|
|
||
| func subscribeToAdvisoryUpdates(wg *sync.WaitGroup, readerBuilder mqueue.CreateReader) { | ||
| handler := mqueue.MakeRetryingHandler(advisoryUpdateHandler) | ||
| for i := 0; i < consumerCount; i++ { | ||
| mqueue.SpawnReader(base.Context, wg, advisoryUpdateTopic, readerBuilder, handler) | ||
| utils.LogDebug("spawned advisory update reader", i) | ||
| } | ||
| utils.LogInfo("connected to kafka topics") | ||
| } | ||
|
|
||
| func RunAggregator() { | ||
| var wg sync.WaitGroup | ||
|
|
||
| utils.LogInfo("aggregator starting") | ||
| core.ConfigureApp() | ||
| readPodConfig() | ||
| configure() | ||
|
|
||
| go runServer() | ||
| go utils.RunProfiler() | ||
| subscribeToAdvisoryUpdates(&wg, mqueue.NewKafkaReaderFromEnv) | ||
|
|
||
| wg.Wait() | ||
| utils.LogInfo("aggregator completed") | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| package aggregator | ||
|
|
||
| import ( | ||
| "app/base/mqueue" | ||
| ) | ||
|
|
||
| // TODO: stub - will process advisory update events in batches and update account_advisory table | ||
| func advisoryUpdateHandler(m mqueue.KafkaMessage) error { | ||
| return nil | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| package aggregator | ||
|
|
||
| import ( | ||
| "app/base/mqueue" | ||
| "app/base/utils" | ||
| ) | ||
|
|
||
| var notificationsPublisher mqueue.Writer | ||
|
|
||
| func configureNotifications() { | ||
| if topic := utils.CoreCfg.NotificationsTopic; topic != "" { | ||
| notificationsPublisher = mqueue.NewKafkaWriterFromEnv(topic) | ||
|
Comment on lines
+10
to
+12
There was a problem hiding this comment. suggestion (bug_risk): Align
Suggested implementation: func configureNotifications() {
// Only initialize the notifications writer if notifications are enabled
if !enableNotifications {
return
}
if topic := utils.CoreCfg.NotificationsTopic; topic != "" {
notificationsPublisher = mqueue.NewKafkaWriterFromEnv(topic)
}
}To fully align
|
||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| POD_CONFIG=label=aggregator |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| DB_USER=evaluator | ||
| DB_PASSWD=evaluator |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: Consider validating
consumer_countto avoid silently running with zero consumersIf
consumer_countis set to 0 or negative, no readers will be spawned and the service will appear healthy while not consuming messages. Consider enforcing a minimum of 1 (e.g., clamp<= 0to 1 and log a warning) to guard against misconfiguration.Suggested implementation: