fix(llms): require a fully-qualified base URL for link rewriting - #1613
Open
neon60 wants to merge 1 commit into
Open
fix(llms): require a fully-qualified base URL for link rewriting#1613neon60 wants to merge 1 commit into
neon60 wants to merge 1 commit into
Conversation
_resolve_base_url accepted any truthy candidate, so a scheme-less html_baseurl such as "instinct.docs.amd.com" was emitted verbatim, producing malformed links like "instinct.docs.amd.com/page.html" in llms.txt and llms-full.txt. Validate each candidate with urlparse and use it only when it has both a scheme and a netloc; otherwise warn and fall back to relative links. Co-Authored-By: Claude Opus 4 (1M context) <noreply@anthropic.com>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
_resolve_base_url accepted any truthy candidate, so a scheme-less html_baseurl such as "instinct.docs.amd.com" was emitted verbatim, producing malformed links like "instinct.docs.amd.com/page.html" in llms.txt and llms-full.txt. Validate each candidate with urlparse and use it only when it has both a scheme and a netloc; otherwise warn and fall back to relative links.
Technical Details
Test Plan
Test Result
Submission Checklist