cmake: add opt-in portable RPATHs for TheRock ROCm wheels - #3549
Draft
sa-faizal wants to merge 1 commit into
Draft
cmake: add opt-in portable RPATHs for TheRock ROCm wheels#3549sa-faizal wants to merge 1 commit into
sa-faizal wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default
CMAKE_INSTALL_RPATH_USE_LINK_PATHpolicy copies build-environment ROCm library directories into installed wheel RUNPATHs. Those absolute paths do not exist in a clean installation.Add an opt-in
THEROCK_PYTORCH_PORTABLE_RPATHpolicy that:$ORIGINfor Torch's own libraries;_rocm_sdk_coreand_rocm_sdk_libraries;The option defaults to
OFF, so existing builds retain their current behavior. The libtorchless MKL override also respects the opt-in policy.Validation:
CMAKE_INSTALL_RPATH_USE_LINK_PATH=FALSEwhen enabled.git diff --checkpasses.Stacked follow-up: ROCm/TheRock#7210 enables this option for its production PyTorch wheel builder and rejects absolute wheel RPATH/RUNPATH entries before publishing artifacts.