[CI] Parity: replace ROCm nightly with scheduled Preview - #3406
Closed
ethanwee1 wants to merge 2 commits into
Closed
[CI] Parity: replace ROCm nightly with scheduled Preview#3406ethanwee1 wants to merge 2 commits into
ethanwee1 wants to merge 2 commits into
Conversation
Adds a "preview" ROCm arch so parity can be run against the upstream rocm-preview lane (linux-noble-rocm-preview-py3.12-gfx942, gfx942), which runs the TheRock preview wheel (e.g. ROCm 7.14) via the ciflow/rocm-preview label. default/distributed/inductor all come from the single rocm-preview workflow (6/3/2 shards). - parity_job_config.json: new rocm.preview entry. - download_testlogs: allow --arch preview. - parity.yml: list preview as an arch option. Because rocm-preview is ciflow-triggered (not scheduled on main), this arch is for manual/on-demand parity runs against a rocm-preview commit; it is intentionally not added to the auto-trigger scope.
1 task
|
Jenkins build for 58cb4d0e111ca0b6ee73fac7fce8f7c05b041fea commit finished as FAILURE |
Collaborator
|
This will also benefit from the changes to look at the yaml file, so will merge this after. |
Update the Preview lane to its live mi350 job prefix and 8/3/2 matrix, and retire the obsolete nightly CLI/config key.
ethanwee1
changed the title
This was referenced Aug 11, 2026
Author
|
Superseded by clean current-develop replacement #3554. The old branch predates the develop history reset and cannot be merged normally without rewriting history. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the retired
nightlyparity topology with the current daily scheduledrocm-previewlane.Changes
previewis the only Preview CLI/config key;nightlyis removed.rocm-previewandlinux-noble-rocm-preview-py3.12-mi350.parity.ymldocumentspreviewinstead ofnightly.Auto-trigger discovery is implemented in #3397 so this PR remains focused on downloader/config support.
Validation
download_testlogscompilesparity.ymlparses as YAMLDependencies
Land before or with #3397. Downloader topology discovery in #3535 should consume this configuration without hardcoded shard dependence.