(feat) Enable MLX5 + MI300X CI - #560
Open
QizhouZhang97 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
On mlx5 hosts without a working peer-memory bridge, DEVX registration of GPU
memory fails with EFAULT and MORI aborts at
assert(cqUmem). Peer-memory ismissing from inbox
ib_uverbs, and OFED cannot supply it on kernels >= 6.3:ib_register_peer_memory_clientis exported non-GPL, sosymbol_get()rejectsit and amdgpu's peer-direct bridge never registers.
Technical Details
Register the GPU CQ/QP/DBR umems and the atomic ibuf through dmabuf
(
mlx5dv_devx_umem_reg_ex,ibv_reg_dmabuf_mr), which pins viaib_umem_dmabuf_get_pinnedand needs no peer-memory client. Both helpers fallback to by-address registration, so hosts that already work are unaffected. The
symbol is resolved optionally and its descriptor vendored, keeping the build
green on rdma-core v39. Also tolerates
hipErrorHostMemoryAlreadyRegisteredwhen sibling QPs share a UAR page.
CI gains an
MI300X_MLXplatform (2x MI300X, 8x CX-7 NDR InfiniBand). SL/TC areomitted -- mlx5 applies them only on the RoCE path.
Test Result
Two-node EP dispatch/combine (v1, v1_ll, async_ll), bit-exact hierarchical
AllGather, and MORI-IO all pass on the new runner.