perf(cco): preserve global address space in LSA pointer wrapper - #537
Open
yangyuhuiling wants to merge 1 commit into
Open
perf(cco): preserve global address space in LSA pointer wrapper#537yangyuhuiling wants to merge 1 commit into
yangyuhuiling wants to merge 1 commit into
Conversation
Restore the global-memory provenance erased by the scalar DSL handle so LSA window metadata uses global loads instead of conservative flat loads.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ccoWindow_tmetadata objects are allocated in device global memoryaddrspace(1)after the scalar FlyDSL ABI converts the window handle touint64_tcco_lsa_ptrAPI while allowing AMDGPU to selectglobal_loadinstead of conservative genericflat_loadPerformance
With the current EPv2 kernel held fixed and only the linked CCO bitcode switched:
Source-mapped ATT shows
flat_load_dwordx3plusvmcnt/lgkmcntwaits becomingglobal_load_dwordx3; the scatter kernel also drops from 24 to 16 reported VGPRs with no scratch use.Test plan
cco_device_wrapper.cppto gfx950 device bitcodecco_lsa_ptrIR usesptr addrspace(1)for metadata loadsexamples/cco/python/04_flydsl_lsa_puton 2 ranks2 passed)Made with Cursor