fix(run_orchestrator): preserve multiple_results in MAD_CONTAINER_IMAGE synthetic manifest - #166
Merged
Conversation
MAD_CONTAINER_IMAGE (local image) mode built a synthetic manifest that omitted the models.json `multiple_results` field. Without it, ContainerRunner never sets MAD_OUTPUT_CSV, never copies the perf CSV out of the container, and falls back to scraping the run log for a "performance: NUMBER METRIC" line -- reporting FAILURE even when the model produced valid perf-CSV results. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
coketaste
requested review from
Cemberk,
Rohan138,
gargrahul and
leconcio
as code owners
August 10, 2026 22:37
There was a problem hiding this comment.
Pull request overview
This PR fixes local-image (MAD_CONTAINER_IMAGE) execution by ensuring the synthetic build_manifest.json produced by RunOrchestrator._create_manifest_from_local_image() preserves the multiple_results field from models.json, which ContainerRunner relies on to set MAD_OUTPUT_CSV and correctly export perf CSV results.
Changes:
- Preserve
multiple_resultswhen constructing syntheticbuilt_modelsentries for local-image runs. - Add unit tests verifying
multiple_resultsis preserved when provided and defaults to""when absent.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/madengine/orchestration/run_orchestrator.py |
Adds multiple_results to the synthetic manifest’s built_models entries so local-image runs follow the same manifest schema as built-image runs. |
tests/unit/test_orchestration.py |
Adds unit coverage to prevent regressions for multiple_results propagation and defaulting behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
from models.json.
line — reporting FAILURE (no performance metrics) even when the model produced a fully valid perf CSV.
ran via local-image mode.
Fix
through.
Test plan