gpuagent: migrate amdsmi_set_gpu_clk_range to amdsmi_set_gpu_clk_limit - #88
Merged
Merged
Conversation
amdsmi_set_gpu_clk_range is removed in the latest amdsmi (ROCm 10.x), breaking the gpuagent build. Set the min then max clock limit via amdsmi_set_gpu_clk_limit (AMDSMI_CLK_LIMIT_MIN/MAX), matching the change made in pensando/sw #119381. Bump the vendored amdsmi from 26.4.0 (therock-7.13.0) to 27.0.0 (therock-10.1.0a20260812) so the AMDSMI_CLK_LIMIT_* enum is available to the in-repo build. The 27.0.0 libamd_smi.so DT_NEEDs the namespaced rocm_sysdeps netlink libs, so vendor librocm_sysdeps_nl_3, nl_genl_3 and mnl alongside it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
amdsmi_set_gpu_clk_range is removed in the latest amdsmi (ROCm 10.x), breaking the gpuagent build. Set the min then max clock limit via amdsmi_set_gpu_clk_limit (AMDSMI_CLK_LIMIT_MIN/MAX), matching the change made in pensando/sw #119381.
Bump the vendored amdsmi from 26.4.0 (therock-7.13.0) to 27.0.0 (therock-10.1.0a20260812) so the AMDSMI_CLK_LIMIT_* enum is available to the in-repo build. The 27.0.0 libamd_smi.so DT_NEEDs the namespaced rocm_sysdeps netlink libs, so vendor librocm_sysdeps_nl_3, nl_genl_3 and mnl alongside it.
Motivation
Technical Details
Test Plan
Test Result
Submission Checklist