Fix test_split_batch pickling on Python 3.14 - #339
Open
nemanjaudovic wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Python 3.14 changed the default multiprocessing start method on Linux to
forkserver. This requiresDataLoaderworker arguments to be picklable, buttest_split_batchdefines its dataset class inside the test method.Move the dataset class to module scope so it can be pickled by workers while preserving the existing
num_workers=2coverage.Testing
test_batch_sampler.TestBatchSamplerBehavior.test_split_batchwith Python 3.14 and confirm it passes using the defaultforkserverstart method.