[PERF] Optimize Triton unified attention prefill and decode - #4761
Draft
vorapolsiloai wants to merge 1 commit into
Draft
[PERF] Optimize Triton unified attention prefill and decode#4761vorapolsiloai wants to merge 1 commit into
vorapolsiloai wants to merge 1 commit into
Conversation
…al-mask-skip kernel optimization
Contributor
🏷️ CI GuideRuns automatically on every PR:
Extended tests (opt-in via labels):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This rebases the validated optimization from 389fb3d3 onto current
mainwhile preserving Mohsen Saffari's authorship.Performance validation
Tested end-to-end with Qwen3-VL-235B-A22B-Instruct-MXFP4 by applying only this AITER change to the same pinned vLLM Image C base. Results use same-device/pair crossover placement; one thermally throttled GPU was detected and excluded.
Test plan
mainat 1b741c0git diff --check upstream/main...HEADReview notes
The PR is intentionally draft while the upstream correctness suite and CI are pending. The kernel fast loop is prefill-only; sliding-window and decode calls retain the general masked loop. The launch overrides are restricted by dtype, head size, GQA ratio, architecture, sequence length, and batch conditions documented inline.
Made with Cursor