fix: LL proto ar dispatch - #4753
Open
TennyWang1223 wants to merge 1 commit into
Open
Conversation
Signed-off-by: TennyWang1223 <tennwang@amd.com>
Contributor
🏷️ CI GuideRuns automatically on every PR:
Extended tests (opt-in via labels):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
DeepSeek decode uses allreduce shapes
(16, 7168)and(32, 7168)bf16 (224/448 KB). These fell through to the barrier-basedar_gfx1250_naive_unroll4because the LL threshold was only 128 KiB. Raise it so these cases route to the faster flag-in-data
ar_ll_gfx1250kernel.Technical Details
Changes in
csrc/include/custom_all_reduce_gfx1250.cuh:kLLArMaxBytes: 128 KiB → 4 MiBkLLScratchCapBytes: 256 KiB → 4 MiB (scratch capacity to match)allreduce_llblock size:bytes < 65536→ 512 threads, otherwise 256ar_ll_gfx1250__launch_bounds__:(256, 2)→(512, 1)Test Plan
python op_tests/multigpu_tests/gfx1250_poc/test_gfx1250_allreduce.py
-s 16,7168 -s 32,7168 -d bf16 -g true -t 4 --check-arch
Test Result
Submission Checklist