ci: centralize PyTorch test image config - #4750
Open
gyohuangxin wants to merge 2 commits into
Open
Conversation
Contributor
🏷️ CI GuideRuns automatically on every PR:
Extended tests (opt-in via labels):
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR centralizes the ROCm PyTorch Docker image tags used in CI by introducing a reusable workflow that exposes image values as outputs, and then wiring existing CI workflows to consume those outputs instead of hardcoding image tags.
Changes:
- Add
.github/workflows/ci-config.yamlreusable workflow to provide shared outputs (PyTorch image tags + Triton wheel artifact name). - Update multiple CI workflows to
needs: ci_configand readneeds.ci_config.outputs.*for Docker images (and Triton artifact naming where applicable). - Adjust Triton workflow path filtering so workflow-only edits (including the new config workflow) still trigger the Triton tests.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/ci-config.yaml | New reusable workflow exporting centralized ROCm PyTorch image tags and shared artifact naming. |
| .github/workflows/aiter-test.yaml | Consume centralized image/artifact outputs; update PR path filters to include the shared workflows. |
| .github/workflows/triton-test.yaml | Consume centralized image/artifact outputs; re-include workflow files in path filters after broad exclusions. |
| .github/workflows/prepare-triton-wheel.yaml | Make docker-image input required (removing default) to enforce explicit caller configuration. |
| .github/workflows/opus-test.yaml | Replace hardcoded image with centralized ci_config output. |
| .github/workflows/operators-tuning.yaml | Replace hardcoded image with centralized ci_config output for container runs. |
| .github/workflows/tuning-tests.yaml | Move from global DOCKER_IMAGE to per-job ci_config output usage. |
| .github/workflows/flash_attention_integration.yaml | Add ci-config.yaml to path triggers and use centralized base image output in dependent jobs. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
83
to
86
| with: | ||
| docker-image: rocm/pytorch:latest | ||
| artifact-name: triton_wheelhouse | ||
| docker-image: ${{ needs.ci_config.outputs.pytorch_py312_image }} | ||
| artifact-name: ${{ needs.ci_config.outputs.triton_wheel_artifact_name }} | ||
| retention-days: 3 |
gyohuangxin
force-pushed
the
ci/pin-ci-pytorch-2.10-image
branch
from
August 14, 2026 06:51
97701e2 to
420cbae
Compare
valarLip
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation