Skip to content

hd256 fp8 attention perf improvement - #4733

Open
JohnNikolay84 wants to merge 1 commit into
mainfrom
hd256_f8_attention_perf_tune
Open

hd256 fp8 attention perf improvement#4733
JohnNikolay84 wants to merge 1 commit into
mainfrom
hd256_f8_attention_perf_tune

Conversation

@JohnNikolay84

Copy link
Copy Markdown
Contributor

Motivation

Attention is one of the biggest bottleneck for Qwen3.* models especially for larger ISL.

Technical Details

Optimize softmax in hd256 f8 attention.

Test Plan

python op_tests/test_mha_varlen_fp8.py -q 32768 -n 16 -b 1 -nk 2 -d 256 -c

  • model tests.

Test Result

aiter tests shows improvement from 5 to 5.8 PFlops ( 15.8% )

Submission Checklist

@github-actions

Copy link
Copy Markdown
Contributor

🏷️ CI Guide

Runs automatically on every PR:

  • ✅ Pre-checks (submodule verification, code formatting)
  • ✅ Aiter op tests (gfx942 + gfx950)
  • ✅ Triton tests on MI35X (only when aiter/ops/triton/** or related paths are changed)

Extended tests (opt-in via labels):

Label Tests
ci:gfx1250-ffm-triton Run the five-shard gfx1250 FFM Triton test suite
ci:triton-300x Run an additional Triton test job on MI300X in PRs; main branch always runs both MI35X and MI300X
ci:sglang SGLang integration tests: DeepSeek-R1-MXFP4 accuracy, Qwen 3.5 accuracy
ci:atom ATOM benchmark: DeepSeek-R1-0528, GPT-OSS-120B
ci:atom_full ATOM accuracy suite for PR and main models from ATOM models_accuracy.json
ci:vllm vLLM benchmark: GPT-OSS-120B, DeepSeek-R1-0528, Kimi-K2.5
ci:all All standard extended tests (excludes ci:atom_full)

Only add ci:atom_full for FlyDSL or Triton upgrades.
Add labels via the sidebar or gh pr edit 4733 --add-label <label>

@JohnNikolay84
JohnNikolay84 force-pushed the hd256_f8_attention_perf_tune branch from 7d5b0e9 to 4af1556 Compare August 13, 2026 22:59
@zufayu
zufayu requested a review from amd-ruitang3 August 14, 2026 01:31
@JohnNikolay84
JohnNikolay84 requested a review from valarLip August 14, 2026 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants