Implements the "maintenance info amdgpu address-aliases" command - #225
Open
czidev-amd wants to merge 1 commit into
Open
Implements the "maintenance info amdgpu address-aliases" command#225czidev-amd wants to merge 1 commit into
czidev-amd wants to merge 1 commit into
Conversation
czidev-amd
force-pushed
the
users/czissule/address-alias
branch
from
July 21, 2026 12:45
3d2d94b to
d234a73
Compare
czidev-amd
changed the title
lumachad
reviewed
Jul 22, 2026
czidev-amd
marked this pull request as draft
July 27, 2026 11:39
czidev-amd
marked this pull request as draft
July 27, 2026 11:39
czidev-amd
force-pushed
the
users/czissule/address-alias
branch
2 times, most recently
from
July 27, 2026 15:08
dbe0775 to
1432895
Compare
czidev-amd
commented
Jul 27, 2026
czidev-amd
left a comment
czidev-amd
left a comment
Contributor
Author
There was a problem hiding this comment.
Thank you @lumachad for your review, I have reworked a bit this PR to include your comments. One observation is the renaming of the tests to match other "maint" tests naming pattern. Also, I have relaxed the test as I cannot really guarantee the same output across different architectures. Now, the tests is testing if gdb implementation is sane rather than gdbabi output sanity.
czidev-amd
marked this pull request as ready for review
July 27, 2026 15:14
palves
reviewed
Jul 27, 2026
lancesix
reviewed
Jul 27, 2026
czidev-amd
force-pushed
the
users/czissule/address-alias
branch
from
July 28, 2026 11:36
1432895 to
2f1c254
Compare
Contributor
Author
|
I have spined a new version including Pedro's and Lancelot's inputs. |
1 task
lumachad
reviewed
Jul 30, 2026
aktemur
reviewed
Jul 30, 2026
| /* Not a real alias, NULL just maps to NULL in every | ||
| space. */ | ||
| if (src_is_null_address) | ||
| ui_out->field_string ("valid", "<null>"); |
Contributor
There was a problem hiding this comment.
IMHO it wouldn't be wrong to print 0 here.
Contributor
Author
There was a problem hiding this comment.
I can do that, let's see if anyone else has a different idea.
palves
reviewed
Jul 30, 2026
lancesix
reviewed
Aug 4, 2026
| Some address spaces are private to a wave or a lane of a wave, and | ||
| @value{GDBN} converts using whichever wave and lane are currently | ||
| selected. Not every address is reachable from every space: if it isn't, | ||
| the row for that space reads @samp{<not reachable>}. |
Collaborator
There was a problem hiding this comment.
One nit, I think that we do an LDS -> global conversion, but this is only valid (ish) while the wave is stopped. As soon as we resume, this address is not valid anymore. Not sure if this should be described, or maybe this is just a dbgapi bug we should address.
czidev-amd
force-pushed
the
users/czissule/address-alias
branch
from
August 4, 2026 13:39
2f1c254 to
9b0c0d2
Compare
aktemur
reviewed
Aug 13, 2026
czidev-amd
marked this pull request as draft
August 17, 2026 11:10
czidev-amd
force-pushed
the
users/czissule/address-alias
branch
from
August 17, 2026 11:16
9b0c0d2 to
ec37ff2
Compare
It can sometimes be useful to be able to convert address from an
address space to another one (if such conversion is possible). This
patch proposes to add a maintenance command which shows for a given
address (in any address space) the aliasing addresses in other address
spaces. It also shows the number of consecutive bytes this conversion
is valid for.
Here are example outputs on this new command:
(gdb) maintenance info amdgpu address-aliases &idx
Address space Address Valid for
global 0x7ff7f4600c00 0x4
generic generic#0x2000000000030 0x3d0
private_wave private_wave#0xc00 0x4
private_lane private_lane#0x30 0x3d0
local <not reachable> 0x0
(gdb) maintenance info amdgpu address-aliases gidx_p
Address space Address Valid for
global <not reachable> 0x0
generic generic#0x1000000000000 0x200
private_wave <not reachable> 0x0
private_lane <not reachable> 0x0
local local#0x0 0x100000000
Tested on x86_64-linux + gfx942.
Change-Id: I9d118f208589c3db6a2ec966ac221b1a54d0ccb6
Co-authored-by: Claudiu Zissulescu-Ianculescu <claudiu.zissulescu-ianculescu@amd.com>
czidev-amd
force-pushed
the
users/czissule/address-alias
branch
from
August 17, 2026 13:14
ec37ff2 to
866d8c3
Compare
czidev-amd
marked this pull request as ready for review
August 17, 2026 13:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Given an expression that evaluates to an address in some address space, show for each address space supported by the current AMDGPU architecture the aliasing address in that space, if any, along with the number of consecutive bytes for which the aliasing is valid.
This is purely a diagnostic aid: it queries amd_dbgapi_convert_address_space for every address space known to the architecture and reports "" for the ones the given address does not alias into.
Test Plan
New
show_address_aliases.exptest added.