[WS2][PR5][Attention] Add distributed CP drift benchmark artifacts - #285
Open
inaniloquentee wants to merge 1 commit into
Open
[WS2][PR5][Attention] Add distributed CP drift benchmark artifacts#285inaniloquentee wants to merge 1 commit into
inaniloquentee wants to merge 1 commit into
Conversation
Signed-off-by: inaniloquentee <3051000145@qq.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Windows / local CI checks:
pre-commit run --all-filespy -3.13 -m pytest tests/test_ws2_cp_attention_drift_benchmark.py tests/test_cp_attention.py tests/test_operator_inputs.py -q(45 passed)py -3.13 -m pytest tests/test_attention.py tests/test_kv_cache_attention.py tests/test_attention_correctness.py -q(85 passed, 83 skipped)py -3.13 -m mypy --ignore-missing-imports rl_engine/py -3.13 -m mkdocs build --strict -f mkdocs.yamlpy -3.13 scripts/check_operator.py --op cp_attention --check-gradpy -3.13 benchmarks/benchmark_ws2_cp_attention_drift.py --smoke --jsonpy -3.13 benchmarks/benchmark_ws2_cp_attention_drift.py --smoke --tp-world-sizes 2 --cp-world-sizes 2 --kv-chunk-sizes none,1 --include-backward --device cpu --output $env:TEMP\ws2-cp-attention-drift-pr5.jsonWSL validation:
python3 -m pytest tests/test_ws2_cp_attention_drift_benchmark.py tests/test_cp_attention.py tests/test_operator_inputs.py -q(45 passed)python3 -m pytest tests/test_attention.py tests/test_kv_cache_attention.py tests/test_attention_correctness.py -q(39 passed, 129 skipped)python3 benchmarks/benchmark_ws2_cp_attention_drift.py --smoke --tp-world-sizes 2 --cp-world-sizes 2 --kv-chunk-sizes none,1 --include-backward --device cpu --jsonpython3 -m torch.distributed.run --nproc-per-node=2 benchmarks/benchmark_ws2_cp_attention_drift.py --smoke --tp-world-sizes 2 --cp-world-sizes 2 --kv-chunk-sizes none --device cpu --jsonNotes:
torchrunwas blocked by the host PyTorch libuv rendezvous build before script launch; WSLtorch.distributed.runpassed for the torchrun-style rank-aware path.Notes
codex/ws2-pr8-cp-attention-backward.