Skip to content

Templates: open URLs in disposables - #665

Open
notmuchtohide wants to merge 6 commits into
QubesOS:mainfrom
notmuchtohide:template-open-url-dvm
Open

Templates: open URLs in disposables#665
notmuchtohide wants to merge 6 commits into
QubesOS:mainfrom
notmuchtohide:template-open-url-dvm

Conversation

@notmuchtohide

@notmuchtohide notmuchtohide commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

This is part of QubesOS/qubes-issues#6310, aiming to open Gnome Software URLs (project website, donation pages, etc.) in disposables.

This allows the user to check the project website safely before installing apps, while reducing the need for screenshots to recognize the apps in Gnome Software (QubesOS/qubes-issues#10983).

Previously, URLs were opened in offline browsers. However, if Gnome Software had access to the updates proxy (e.g. for Flatpak related actions) it would pass the proxy configurations to the browser and open the URL online.

Service ConditionGroup borrowed from qubes-notification-agent.

This is part of QubesOS/qubes-issues#6310, aiming to open Gnome Software
URLs (project website, donation pages, etc.) in disposables.

This allows the user to check the project website safely before
installing apps, while reducing the need for screenshots to recognize
the apps in Gnome Software (QubesOS/qubes-issues#10983).

Previously, URLs were opened in offline browsers. However, if Gnome
Software had access to the updates proxy (e.g. for Flatpak related
actions) it would pass the proxy configurations to the browser and open
the URL online.

Service ConditionGroup borrowed from qubes-notification-agent.
@ben-grande

Copy link
Copy Markdown
Contributor
  1. Have you tried app-dispvm.*?
  2. If that is unsuitable, please use the term dispvm rather than dvm.

@marmarta

marmarta commented Aug 7, 2026

Copy link
Copy Markdown
Member

Have you tried app-dispvm.*?

I'm not sure if this makes sense here, opening all urls in a template in disposables makes I think a lot of sense and is more resilient to other package managers using packagekit or whatnot.

  • If that is unsuitable, please use the term dispvm rather than dvm.

agreed on that

@andrewdavidwong

Copy link
Copy Markdown
Member

Suggestion: If you intend for this pull request to resolve the associated issue and would like for it to be linked to the issue automatically, you can put Closes QubesOS/qubes-issues#XXXX in the PR message (where XXXX is the issue number). Closes is one of several special keywords that GitHub will recognize. If and when the PR is merged, GitHub will automatically close the associated issue.

@codecov

codecov Bot commented Aug 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.71%. Comparing base (a37fac9) to head (e1da340).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #665      +/-   ##
==========================================
+ Coverage   71.31%   71.71%   +0.39%     
==========================================
  Files           3        3              
  Lines         502      502              
==========================================
+ Hits          358      360       +2     
+ Misses        144      142       -2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants