fix(at): use local height for chain-query activation gates - #217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Consensus impact
The height carried into AT execution from an incoming block is not part of the signed block bytes. The affected activation checks now use the repository parent height plus one, matching the existing local-height gate used by neighboring AT features.
This applies to:
GET_TRUST_STATUS_FROM_ACCOUNT_IN_BGET_BALANCE_FROM_ACCOUNT_IN_BCHECK_CODE_HASH_OF_AT_IN_BValidation
-DskipTests=false: 3,004 tests, 0 failures/errors, 68 skipsgit diff --cached --check: cleanScope boundary
This PR completes only T1 / C-01 in
docs/development/ultra-review-remediation-plan.md. The remaining findings stay planned or decision-gated and are not represented as fixed here.