Add the API-key-protected /admin/dbpool endpoint (6.1.9 worksheet) - #216
Merged
Conversation
Completes the accepted 6.1.9 triage worksheet: the only portable delta. Returns the tracked pooled-connection states from HSQLDBRepositoryFactory.getDbConnectionsStates() when connection-pool monitoring is enabled, or an empty list otherwise (and for non-HSQLDB factories). Placed beside /admin/enginestats in the restricted AdminResource with @securityrequirement(name = "apiKey") and Security.checkApiCallAllowed(request) - upstream Qortal ships this endpoint with no auth at all; ours requires the key because it reveals connection allocation state, owning-thread identity, and timestamps. All other 6.1.9 changes were verified already present line by line (denormalized created_when column/index/write path, two-step latest query with Qortium's extra empty-IN guard, no-join lite query, cleanup throttle, cache-configured DB URL without JMX). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Executes the accepted Qortal 6.1.9 triage worksheet (docs/upstream/qortal-6.1.9-comparison.md, merged in #215).
A line-by-line residual-delta verification (dual-model, natively spot-checked) confirmed every other 6.1.9 change is already present in Qortium — the denormalized
created_whencolumn/index/write path, the two-step latest query (where Qortium additionally guards the emptyIN ()case upstream lacks), the no-join lite query, the 6-hour cleanup throttle, and the cache-configured DB URL without JMX. The single portable delta was the/admin/dbpoolmonitoring endpoint: Qortium already had theDbConnectionInfoDTO, the opt-in pool-monitoring setting, and the factory accessor, but no HTTP surface.Ported with one deliberate hardening: upstream ships the endpoint with no auth; ours sits in the restricted
AdminResourcebeside/admin/enginestatswith@SecurityRequirement(name = "apiKey")+Security.checkApiCallAllowed(request), since the response reveals connection allocation state, owning-thread identity, and timestamps. Returns an empty list when monitoring is off or the factory is not HSQLDB.Compile clean. Note for the Node QDN app (recorded separately): this endpoint, like
/data/storage/info, stays invisible to the dashboard until its request catalogue adds it.🤖 Generated with Claude Code