feat: Implement device capability metadata for status computed property fields#875
Merged
allenporter merged 6 commits intoJul 13, 2026
Conversation
Lash-L
reviewed
Jul 13, 2026
| collision_avoid_status: int | None = None | ||
| switch_map_mode: int | None = None | ||
| dock_error_status: RoborockDockErrorCode | None = None | ||
| dock_error_status: RoborockDockErrorCode | None = field(default=None, metadata={"dock_feature": "is_collectable"}) |
Collaborator
There was a problem hiding this comment.
i think this should be gated on has dock, not is collectable. non-collectable docks can error
Lash-L
requested changes
Jul 13, 2026
Lash-L
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements capability metadata on Status and StatusV2 computed properties (using a stacked @field_metadata decorator) and resolves all merge conflicts with upstream.
Issue: #874 874