feat: truncate large payloads in RoborockMessage __repr__#873
Merged
allenporter merged 1 commit intoJul 12, 2026
Merged
Conversation
Lash-L
reviewed
Jul 12, 2026
Comment on lines
+289
to
+290
| def __repr__(self) -> str: | ||
| payload_repr = "None" |
Collaborator
There was a problem hiding this comment.
can we add a little commenting here? Just to make it a bit easier to quickly see what our current form is if we need to change?
Collaborator
There was a problem hiding this comment.
eh actually jk. string at the bottom is probably sufficient
Lash-L
approved these changes
Jul 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a custom
__repr__implementation forRoborockMessagethat truncates payloads (bytes, bytearray, str) exceeding 1024 bytes (defined byMAX_PAYLOAD_REPR_LEN). This prevents large map binary messages from bloating and clogging the debug logs.