Add possibility to per-map override a Custom Floor Plan - #42
Open
java-devil wants to merge 1 commit into
Open
Conversation
Lash-L
self-requested a review
July 23, 2026 13:53
Author
|
@Lash-L some weird shenanigans seem to be happening on your repositories. This PR seems to have somehow fallen in the cracks, and it doesn't display on the open PR list. There is in fact only one PR there, despite the number next to PRs still claming otheriwse. Please confirm that you still have visibility into this issue, and that I don't have to reopen it. There is no urgency to you reviewing the code. I just need a quick "I see you, I'll get to this eventually" ;) |
Collaborator
|
Haha I knew this PR existed! Was confused when I didn't see it. My account was false flagged banned. I got my account back but there's some weirdness. I see it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey follow-up to: #16
There are two alternative solutions to the same problem currently "hanging".
However, based on my personal experience I believe a more user-friendly approach is required. Especially one that is resilient to the map inevitably drifting with time. One which allows the User to manually self-correct at any moment. Preferably from the UI. While supporting multiple floors.
Given HAs limitations - this is the most comprehensive flow that I was able to come up with (safe for something crazy to maintain like a full-blown JS custom card):
Upload Screen
Adjustment Screen
Removal Screen
Full Disclosure
I am no "Pythonista". Nor am I very aware of the idioms of HAs development. I leaned on an LLM quite a bit during development, and it did end up replacing in the end quite a bit of my initial draft. Having said that. I AM a professional SE. I did know what to prompt, what to check, and did so meticulously. This entire effort took a few solid days over many iterations / bugfixes.
Cheers,
Adam