change test pass and test fail colors to match the colours used elsewhere - #266
Open
Overlord360 wants to merge 1 commit into
Open
change test pass and test fail colors to match the colours used elsewhere#266Overlord360 wants to merge 1 commit into
Overlord360 wants to merge 1 commit into
Conversation
Collaborator
Author
|
Technically Qt.green is just #00FF00 and Qt.red is just #FF0000 but might as well dynamically get the values in case that changes in future. Therefore, it'll match the test list colours even if the Qt constants were to suddenly change for some reason. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the same green and red we use in the test list for the test pass / fail