Stdlib: mb_chr/mb_ord Zend stub named params (#23291)#23299
Merged
Conversation
Register Reflection parameter names from php-src mbstring.stub.php so named calls and Reflection match Zend; include spine require for XsltPhpFunctionBridge left out of #23296. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mb_chr/mb_ord(codepoint/string+encoding) inBuiltinParamNames, plus relatedmb_scrub/mb_str_split.Unknown named parameter $codepoint/$string) on VM.ext/xsl/XsltPhpFunctionBridge.phpomitted from Stdlib: XSLTProcessor php:function() VM userland bridge (#22632) #23296 (unblocks spine-coverage / north-star5 step 2).Closes #23291
php-src reference
ext/mbstring/mbstring.stub.php—mb_chr,mb_ord,mb_scrub,mb_str_splitPHP implementation
lib/BuiltinParamNames.phponly (no new C)Test plan
php bin/vm.php test/repro/issue_23291_mb_chr_ord_named_params.php→okmb_chr(codepoint:0x41)/mb_ord(string:'A')+ Reflection namesvendor/bin/phpunit --filter BuiltinParamNamesAliasTest::testMbChrOrdZendStubNamedParamsvendor/bin/phpunit --filter named_args_mb_chr_ord(VM+JIT)php script/check-selfhost-spine-coverage-sync.php→ OK 6565/6565./script/check-generated-docs.sh→ OK./script/ci-fast.sh(running)Pillar 1 note
XsltPhpFunctionBridge.php(this PR fixes).north-star5-verify-faststep4f-mstill fails on both master and this branch (stale gen-0 fingerprint — pre-existing, not introduced here).Made with Cursor