Stdlib: ldap_compare/parse_result/get_dn/attrs (#22177)#23270
Merged
Conversation
Expose Zend compare + result-parse + DN/attribute helpers over existing libldap FFI (php-src ext/ldap/ldap.c); PHP-in-PHP only. Co-authored-by: Cursor <cursoragent@cursor.com>
4 tasks
3 tasks
PurHur
added a commit
that referenced
this pull request
Jul 26, 2026
Pillar 1: cover ext/ldap/ldap_result_builtins.php in compiler_lib_spine_smoke after #23270, and restamp lowering_source_fingerprint (ee06d2eaca13…) so north-star5-verify-fast 4f-m stays green. Blob sha/size unchanged; verified-fresh remains #22642. Co-authored-by: PurHur <PurHur@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ldap_compare,ldap_parse_result,ldap_get_dn,ldap_first_attribute,ldap_next_attribute,ldap_get_values/ldap_get_values_len(php-srcext/ldap/ldap.c).LDAP\ResultEntryfor attribute walk.Test plan
yes, TypeError guards, compare →-1without live LDAPvendor/bin/phpunit --filter Ldap— OK (32)Made with Cursor