Stdlib: ldap_add/delete/modify/modify_batch + *_ext (#22196)#23268
Merged
PurHur merged 1 commit intoJul 26, 2026
Conversation
Wire Zend primary directory write/result-ext surfaces over existing libldap FFI modify trampoline (php-src ext/ldap/ldap.c). Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Jul 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ldap_add/ldap_delete/ldap_modify/ldap_modify_batchplus*_ext/ldap_rename_extover existing libldap FFI (ext/ldap/, php-srcext/ldap/ldap.c).ldap_add_ext_s/ldap_delete_ext_s/ldap_modify_ext_s; ext variants returnLDAP\Resultvia async +ldap_result.$controlsaccepted (ignored in v1, same asldap_exop). Keeps historicalldap_mod_batchalias.Test plan
./script/docker-exec.sh -- bash -lc 'php bin/vm.php test/repro/maintainer_gap_ldap_add_delete_modify_missing.php'Output:
vendor/bin/phpunit --filter Ldap→ OK (28 tests)php script/bootstrap-inventory.php --check+./script/check-generated-docs.sh→ OKphp-src-strict; no new
runtime/*.c.Made with Cursor