Stdlib: Soap\Url / Soap\Sdl on PROFILE=8.4+ (#23230)#23245
Merged
Conversation
PHP 8.4 resource→object opaque types from ext/soap/soap.stub.php — final internal classes with userland new rejected; withheld on reference 8.2. Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Jul 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Soap\Url/Soap\Sdlwhen soap is advertised on language profile ≥8.4 (php-src 8.4 resource→object; child of Stdlib: ext/soap — SoapClient subset (ext/soap parity) #3724)newviaReservedBuiltinClass(Cannot directly construct Soap\Url/Soap\Sdl)$httpurl/$sdlproperty wiringphp-src:
ext/soap/soap.stub.php,ext/soap/soap.c(soap_url_object_get_constructor)PHP-in-PHP:
ext/soap/VmSoapOpaque.php+SoapExtensionPolicy::advertisesOpaqueUrlSdlTypes()— no newruntime/*.cCloses #23230
Test plan
PHP_COMPILER_PROFILE=8.4 php bin/vm.php test/repro/maintainer_gap_soap_url_sdl_84.php→okSoap\Url/Soap\Sdlclass_exists false (phantom phpt)vendor/bin/phpunit --filter SoapExtensionPolicyTestOKPHP_COMPILER_PROFILE=8.4 vendor/bin/phpunit --filter soap_url_sdlOK (VM+JIT)php script/bootstrap-inventory.php --checkOK 6562/6562php script/check-selfhost-spine-coverage-sync.phpOKVerification transcript
Made with Cursor