Stdlib: substr_replace string/replace/offset/length named params (#23183)

[PurHur]

Summary

• Override InternalArgInfo str/repl/start with Zend stub names string/replace/offset/length in BuiltinParamNames so Reflection and named calls match php-src string.stub.php.
• Fix JitSubstrReplace PHI predecessors to use getInsertBlock() after jitCopySlice/JitStringConcat (they leave the builder in a continue block) so AOT module verify succeeds for positional and named calls.
• Closes Regression: substr_replace Reflection names str/repl/start — Zend string/replace/offset; named args rejected (ext/standard/string.c) #23183

Test plan

• php bin/vm.php test/repro/issue_23183_substr_replace_named.php → ok
• ./script/phpunit.sh --filter 'BuiltinParamNamesAliasTest::testSubstrReplaceZendStubNamedParams|named_args_substr_replace' → OK
• Docker AOT: ./phpc build + run named substr_replace(string:…, replace:…, offset:…, length:…) → abXdef / abX
• Docker vendor/bin/phpunit --filter 'substr_replace_named_params|addcslashes_stripcslashes_substr_replace|named_args_substr_replace|testSubstrReplaceZendStubNamedParams' → OK (9 tests)
• ./script/ci-fast.sh — red on master-unrelated check-no-unlimited-memory (maintainer_gap_max_memory_limit_ini_85_ceiling.php from Stdlib: PHP 8.5 max_memory_limit INI ceiling (#23232) #23238); AOT build smoke OK

Verification transcript (Docker)

$ php bin/vm.php test/repro/issue_23183_substr_replace_named.php
ok
$ ./phpc build -o /tmp/sr_named /tmp/sr_named.php && /tmp/sr_named
abXdef
abX
$ vendor/bin/phpunit --filter 'substr_replace_named_params|addcslashes_stripcslashes_substr_replace|named_args_substr_replace|testSubstrReplaceZendStubNamedParams'
OK (9 tests, 24 assertions)

php-src-strict; PHP-in-PHP only (no new C). Reference: ext/standard/string.c / string.stub.php.

Made with Cursor