Skip to content

Added remaining Heavensward FSH class quests#570

Open
ShermTank7272 wants to merge 1 commit into
PunishXIV:new-mainfrom
ShermTank7272:heavensward-fsh
Open

Added remaining Heavensward FSH class quests#570
ShermTank7272 wants to merge 1 commit into
PunishXIV:new-mainfrom
ShermTank7272:heavensward-fsh

Conversation

@ShermTank7272

Copy link
Copy Markdown
Contributor

No description provided.

"AetheryteShortcut": "The Dravanian Forelands - Tailfeather",
"SkipConditions": {
"AetheryteShortcutIf": {
"InSameTerritory": true

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the "InSameTerritory" skip condition doesn't do anything. It was replaced by a proximity check at one point, so this isn't necessary.

Comment on lines +83 to +86
{
"ItemId": 12769,
"ItemCount": 3
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you do not add a fishing present to FishingData.cs, you should instead add a FishingOptions object to the ItemsToGather object. In there, you can set the bait id and hook type. I assume we want to set it to the Versatile Lure. The previous Icepick quest should have an example, though it uses a different bait.

Suggested change
{
"ItemId": 12769,
"ItemCount": 3
}
{
"ItemId": 12769,
"ItemCount": 3,
"FishingOptions": {
"BaitId": 29717,
"HookType": {
"Normal": {
"Strong": true
}
}
}
}

"InteractionType": "WalkTo"
},
{
"Comment": "Fish for 1x Letter Puffer (Bait: Giant Crane Fly)",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would usually include a step to have the player buy the bait before fishing, otherwise it will just start casting with whatever they previously had on and it could easily use up all their bait if it's not compatible with the spot or fish.

"Mount": false
},
{
"Comment": "Fish for 1x Catkiller (Bait: Bladed Steel Jig, Mooch: Bullfrog)\nWEATHER REQUIRED: Clear Skies or Fair Skies",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is one that I would recommend making an AH preset for and setting it up in FishingData.cs. The current fishing preset generator doesn't yet support mooching or weather conditions, but that can be set up in the preset and exported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants