Skip to content

fix(auth): Revert to default credential#1061

Closed
Prajna1999 wants to merge 2 commits into
mainfrom
hotfix/google-aistudio-creds-revert-last-release
Closed

fix(auth): Revert to default credential#1061
Prajna1999 wants to merge 2 commits into
mainfrom
hotfix/google-aistudio-creds-revert-last-release

Conversation

@Prajna1999

@Prajna1999 Prajna1999 commented Jul 22, 2026

Copy link
Copy Markdown
Collaborator

Issue #1060

Summary

  • providers.py: google provider now requires only api_key — dropped project_id, location, sa_key, gcs_bucket from required fields, and sa_key from sensitive fields.
  • mappers.py: removed the guard that rejected text completions on the google provider; google + text now maps to a google-native config and executes via the api-key Gemini client (_execute_text).
  • test_mappers.py: updated the stale rejection test to assert google + text now maps to google-native.

Why it's safe

  • Credential change is strictly more permissive — no existing creds break; full-cred storage still works.
  • The wired GoogleAIProvider needs only api_key; the Vertex provider (google_ai.py) isn't in the registry and has settings fallbacks for every dropped field.
  • Only one test depended on the old behavior; now fixed.

Reviewer confirm

  • ⚠️ sa_key removed from sensitive fields → any existing stored sa_key is now returned unmasked in GET /credentials. No test covers this. Intended?
  • Suite not run live — test DB schema is stale locally.

Checklist

Before submitting a pull request, please ensure that you mark these task.

  • Ran fastapi run --reload app/main.py or docker compose up in the repository root and test.
  • If you've fixed a bug or added code that is tested and has test cases.

Notes

This was a hotfix already deployed to prod. To be merged with main for staging and next steps.

@github-actions github-actions Bot changed the title fix: revert google credential to google_aistudi by default fix(auth): Revert to default credential Jul 22, 2026
@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • ready-for-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 50bead7a-bd00-4846-bb19-968256584779

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch hotfix/google-aistudio-creds-revert-last-release

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

OpenAPI changes   ⚪ No API surface changes

Note

This PR does not modify the API contract.

main624d5a71 · generated by oasdiff

@Prajna1999 Prajna1999 self-assigned this Jul 22, 2026
@Prajna1999

Copy link
Copy Markdown
Collaborator Author

Closing as duplicate to #1061 . The test cases have been taken care by it.

@Prajna1999 Prajna1999 closed this Jul 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant