Skip to content

fix: balance EventLanding hero on wide screens #751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Anshumancanrock wants to merge 1 commit into
base: master
Choose a base branch
from
+114 −58
Open

fix: balance EventLanding hero on wide screens #751

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
110 changes: 61 additions & 49 deletions src/components/EventLanding.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,57 +98,69 @@ export default function EventLanding({ slug }) {
<img src={bannerUrl} alt={pick(locale, event.title)} className={styles.banner} />
)}
<h1 className={styles.title}>{pick(locale, event.title)}</h1>
<div className={styles.meta}>
<span className={styles.metaItem}>
<FontAwesomeIcon icon={faCalendarDays} className={styles.metaIcon} />
{event.endDate
? formatDateRange(event.date, event.endDate, locale)
: formatDate(event.date, locale)}
</span>
<span className={styles.metaItem}>
<FontAwesomeIcon icon={faLocationDot} className={styles.metaIcon} />
{pick(locale, event.location)}
</span>
{event.startTime && (
<span className={styles.metaItem}>
<FontAwesomeIcon icon={faClock} className={styles.metaIcon} />
{event.startTime}
{event.endTime ? ` - ${event.endTime}` : ""}
{event.timeZone ? ` ${event.timeZone}` : ""}
</span>
)}
{event.room && (
<span className={styles.metaItem}>
<FontAwesomeIcon icon={faDoorOpen} className={styles.metaIcon} />
{event.room}
</span>
)}
</div>
<p className={styles.description}>{pick(locale, event.description)}</p>
{(event.externalUrl || event.talkUrl) && (
<div className={styles.heroLinks}>
{event.externalUrl && (
<a
href={event.externalUrl}
className={styles.externalLink}
target="_blank"
rel="noopener noreferrer"
>
{isZh ? "查看活动官网" : "Event Website"} →
</a>
)}
{event.talkUrl && (
<a
href={event.talkUrl}
className={styles.externalLink}
target="_blank"
rel="noopener noreferrer"
>
{isZh ? "查看演讲详情" : "Talk Details"} →
</a>
<div className={styles.heroBody}>
<div className={styles.heroMain}>
<p className={styles.description}>{pick(locale, event.description)}</p>
{(event.externalUrl || event.talkUrl) && (
<div className={styles.heroLinks}>
{event.externalUrl && (
<a
href={event.externalUrl}
className={styles.externalLink}
target="_blank"
rel="noopener noreferrer"
>
{isZh ? "查看活动官网" : "Event Website"} →
</a>
)}
{event.talkUrl && (
<a
href={event.talkUrl}
className={styles.externalLink}
target="_blank"
rel="noopener noreferrer"
>
{isZh ? "查看演讲详情" : "Talk Details"} →
</a>
)}
</div>
)}
</div>
)}
<aside className={styles.heroAside} aria-label={isZh ? "活动信息" : "Event details"}>
<div className={`hami-section-card ${styles.detailsCard}`}>
<div className={styles.meta}>
<span className={styles.metaItem}>
<FontAwesomeIcon icon={faCalendarDays} className={styles.metaIcon} />
<span>
{event.endDate
? formatDateRange(event.date, event.endDate, locale)
: formatDate(event.date, locale)}
</span>
</span>
<span className={styles.metaItem}>
<FontAwesomeIcon icon={faLocationDot} className={styles.metaIcon} />
<span>{pick(locale, event.location)}</span>
</span>
{event.startTime && (
<span className={styles.metaItem}>
<FontAwesomeIcon icon={faClock} className={styles.metaIcon} />
<span>
{event.startTime}
{event.endTime ? ` - ${event.endTime}` : ""}
{event.timeZone ? ` ${event.timeZone}` : ""}
</span>
</span>
)}
{event.room && (
<span className={styles.metaItem}>
<FontAwesomeIcon icon={faDoorOpen} className={styles.metaIcon} />
<span>{event.room}</span>
</span>
)}
</div>
</div>
</aside>
</div>
</div>
</section>

Expand Down
62 changes: 53 additions & 9 deletions src/components/EventLanding.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,34 +19,63 @@
.title {
font-family: var(--hami-font-display);
font-size: var(--hami-text-h1);
margin-bottom: var(--hami-space-16);
margin-bottom: var(--hami-space-24);
color: var(--hami-color-text);
}

.heroBody {
display: grid;
grid-template-columns: minmax(0, 1fr) minmax(240px, 320px);
gap: var(--hami-space-32);
align-items: start;
}

.heroMain {
min-width: 0;
}

.heroAside {
min-width: 0;
}

.detailsCard {
padding: var(--hami-space-24);
position: sticky;
top: calc(var(--ifm-navbar-height) + var(--hami-space-16));
}

.meta {
display: flex;
flex-wrap: wrap;
gap: var(--hami-space-24);
margin-bottom: var(--hami-space-24);
flex-direction: column;
gap: var(--hami-space-16);
margin: 0;
}

.metaItem {
display: inline-flex;
align-items: center;
gap: var(--hami-space-8);
display: flex;
align-items: flex-start;
gap: var(--hami-space-12);
font-size: 1.05rem;
line-height: 1.45;
color: var(--hami-color-muted);
}

.metaItem > span {
min-width: 0;
flex: 1;
}

.metaIcon {
color: var(--hami-color-primary);
font-size: 0.95rem;
width: 0.95em;
height: 0.95em;
flex-shrink: 0;
margin-top: 0.2em;
}

.description {
max-width: 720px;
margin: 0;
font-size: 1.1rem;
line-height: 1.7;
color: var(--hami-color-muted);
Expand All @@ -56,7 +85,7 @@
display: flex;
flex-wrap: wrap;
gap: var(--hami-space-16);
margin-top: var(--hami-space-16);
margin-top: var(--hami-space-24);
}

.externalLink {
Expand Down Expand Up @@ -213,3 +242,18 @@
.btnIcon {
margin-right: var(--hami-space-8);
}

@media (max-width: 996px) {
.heroBody {
grid-template-columns: 1fr;
gap: var(--hami-space-24);
}

.heroAside {
order: -1;
}

.detailsCard {
position: static;
}
}