Skip to content

feat(events): add event index page and back navigation - #747

Merged
rootsongjc merged 2 commits into
masterfrom
add-landing-page-list
Aug 10, 2026
Merged

feat(events): add event index page and back navigation#747
rootsongjc merged 2 commits into
masterfrom
add-landing-page-list

Conversation

@fishman

@fishman fishman commented Aug 9, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

Add /landing index page listing all events, link back to it from
event detail pages, and extract i18n helpers into src/utils/i18n.

Summary by CodeRabbit

  • New Features
    • Added a localized events landing page with event titles, dates, locations, and links to event details.
    • Added navigation links to return to the events landing page and browse more events.
    • Added event cards with improved layout, spacing, hover effects, and metadata styling.
    • Added Chinese-language detection and fallback support for event content and page metadata.
    • Added support for displaying both single-event dates and date ranges.

@hami-robot
hami-robot Bot requested review from wawa0210 and windsonsea August 9, 2026 18:20
@netlify

netlify Bot commented Aug 9, 2026 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for project-hami ready!

Name Link
🔨 Latest commit fe7483d
🔍 Latest deploy log https://app.netlify.com/projects/project-hami/deploys/6a796a4d745f490008f337ff
😎 Deploy Preview https://deploy-preview-747--project-hami.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@hami-robot hami-robot Bot added the size/L label Aug 9, 2026
@github-actions github-actions Bot added area/ui and removed size/L labels Aug 9, 2026
@coderabbitai

coderabbitai Bot commented Aug 9, 2026 •
edited
Loading

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 595614f5-4981-4c89-8020-d847917233eb

📥 Commits

Reviewing files that changed from the base of the PR and between 1364133 and fe7483d.

📒 Files selected for processing (2)
  • src/components/EventLanding.js
  • src/pages/landing/index.js
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/components/EventLanding.js
📝 Walkthrough

Walkthrough

Adds a localized /landing events index. Event pages now include localized links to the index and /events. Shared locale helpers replace local implementations, and CSS adds index, card, and backlink styling.

Changes

Events landing experience

Layer / File(s) Summary
Localization and event-page navigation
src/utils/i18n.js, src/components/EventLanding.js, src/components/EventLanding.module.css		 Adds shared Chinese-locale detection and localized value selection. Adds localized links from event pages to /landing and /events, with corresponding navigation styles.
Localized events index
src/pages/landing/index.js, src/components/EventLanding.module.css		 Adds EventLandingList, which renders localized event titles, locations, dates, metadata, and links to /landing/{slug} pages. Adds event list and card styles.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: windsonsea

Sequence Diagram(s)

sequenceDiagram
  participant Visitor
  participant EventLandingList
  participant EventLanding
  Visitor->>EventLandingList: Open /landing
  EventLandingList-->>Visitor: Render localized event links
  Visitor->>EventLanding: Open /landing/{slug}
  EventLanding-->>Visitor: Render event details and navigation links
Loading
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main changes: adding an event index page and back navigation for event detail pages.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch add-landing-page-list

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@hami-robot hami-robot Bot added the size/L label Aug 9, 2026
@fishman
fishman force-pushed the add-landing-page-list branch from 1364133 to a8d6110 Compare August 10, 2026 02:43
@rootsongjc

rootsongjc commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

I have a question: we already have an event index, so why do we need another landing index page? Are they duplicates?

rootsongjc
rootsongjc reviewed Aug 10, 2026
View reviewed changes
Comment thread src/pages/landing/index.js Outdated
<main className={styles.page}>
<section className={styles.hero}>
<div className="container">
<h1 className={styles.title}>{isZh ? "活动" : "Events"}</h1>

@rootsongjc rootsongjc Aug 10, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title is duplicated with the /events page.

Reza Jelveh added 2 commits August 10, 2026 14:02
Reza Jelveh
feat(events): add event index page and back navigation
0c07de0 
Add /landing index page listing all events, link back to it from
event detail pages, and extract i18n helpers into src/utils/i18n.

Fixes #652

Signed-off-by: Reza Jelveh <fishmangit@dynamia.ai>
Reza Jelveh
fix(landing): update labels and navigation for landing pages
fe7483d 
Signed-off-by: Reza Jelveh <fishmangit@dynamia.ai>
@fishman
fishman force-pushed the add-landing-page-list branch from a8d6110 to fe7483d Compare August 10, 2026 06:06
rootsongjc
rootsongjc approved these changes Aug 10, 2026
View reviewed changes

@rootsongjc rootsongjc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@hami-robot hami-robot Bot added the lgtm label Aug 10, 2026
@hami-robot

hami-robot Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fishman, rootsongjc
Once this PR has been reviewed and has the lgtm label, please assign windsonsea for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rootsongjc
rootsongjc merged commit 15f12ab into master Aug 10, 2026
13 of 14 checks passed
@rootsongjc
rootsongjc deleted the add-landing-page-list branch August 10, 2026 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rootsongjc rootsongjc rootsongjc approved these changes
@wawa0210 wawa0210 Awaiting requested review from wawa0210
@windsonsea windsonsea Awaiting requested review from windsonsea

Assignees

@rootsongjc rootsongjc

Labels

area/ui dco-signoff: yes kind/feature new function lgtm size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fishman @rootsongjc