Skip to content

fix: correct CTA spacing on Events page and add missing Event structured-data fields (#725) #742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rootsongjc merged 6 commits into from
Aug 13, 2026
Merged

fix: correct CTA spacing on Events page and add missing Event structured-data fields (#725) #742

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e276a98
fix: correct CTA spacing on Events page and add missing Event structu…
Akashstzt Aug 8, 2026
6c00ae4
fix: split multi-speaker performer field into separate Person entries
Akashstzt Aug 8, 2026
622c09a
fix: only emit offers when real ticket data exists; reflect true avai…
Akashstztt Aug 8, 2026
27e0b77
fix: use single source for eventStatus/availability; add performer field
Akashstztt Aug 9, 2026
61a62c8
style: run prettier on EventLanding.js
Akashstztt Aug 12, 2026
92efef9
Update src/data/events.js
Akashstztt Aug 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions src/components/EventLanding.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,8 @@ export default function EventLanding({ slug }) {
</Layout>
);
}
const effectiveEventStatus = event.eventStatus || "EventScheduled";

const eventJsonLd = {
"@context": "https://schema.org",
"@type": "Event",
Expand All @@ -72,6 +74,34 @@ export default function EventLanding({ slug }) {
description: pick(locale, event.description),
image: bannerUrl ? `${siteConfig.url}${bannerUrl}` : undefined,
eventAttendanceMode: "https://schema.org/OfflineEventAttendanceMode",
eventStatus: `https://schema.org/${effectiveEventStatus}`,
organizer: {
"@type": "Organization",
name: "HAMi",
url: "https://project-hami.io/",
},
...(event.speaker
? {
performer: event.speaker
.split(",")
.map((name) => ({ "@type": "Person", name: name.trim() })),
}
: {}),
...(event.price !== undefined || event.externalUrl
? {
offers: {
"@type": "Offer",
url: event.externalUrl || `${siteConfig.url}/events/${event.slug}`,
price: event.price ?? "0",
priceCurrency: event.priceCurrency || "USD",
availability:
effectiveEventStatus === "EventScheduled"
? "https://schema.org/InStock"
: "https://schema.org/SoldOut",
validFrom: event.offerValidFrom || event.date,
},
}
: {}),
};

return (
Expand Down
2 changes: 2 additions & 0 deletions src/data/events.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ const events = [
zh: "从项目到生产：HAMi 与 Viettel Cloud 亮相 KCD 越南",
},
date: "2026-07-25",
speaker: "Reza Jelveh, The Anh Nguyen",
location: {
en: "Hanoi, Vietnam",
zh: "越南 河内",
Expand Down Expand Up @@ -47,6 +48,7 @@ const events = [
zh: "HAMi 亮相 KubeCon 日本 2026",
},
date: "2026-07-28",
speaker: "Jeonghyun Kim, Reza Jelveh",
endDate: "2026-07-30",
location: {
en: "Yokohama, Japan",
Expand Down
6 changes: 3 additions & 3 deletions src/pages/events.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,17 +295,17 @@
}

.ctaList {
margin: 0 0 var(--hami-space-32);
margin: 0 auto var(--hami-space-32);
padding: 0 0 0 2rem;
display: inline-flex;
display: flex;
flex-direction: column;
gap: var(--hami-space-8);
color: var(--hami-color-muted);
font-size: 0.96rem;
line-height: 1.6;
text-align: left;
max-width: fit-content;
}

/* ── dark mode ── */

[data-theme="dark"] .dayCard {
Expand Down