FOUR-32357 REGRESSION>> Intermediate Signal Throw Event is not working#8932
Open
gproly wants to merge 1 commit into
Open
FOUR-32357 REGRESSION>> Intermediate Signal Throw Event is not working#8932gproly wants to merge 1 commit into
gproly wants to merge 1 commit into
Conversation
Description:
Fix intermediate signal throw when storage/app/private is missing
ThrowSignalEvent calls packTemporalData() in its constructor; that helper
wrote to storage_path('app/private') without ensuring the directory exists.
On develop-qa the folder was absent, causing file_put_contents to fail and
blocking the signal before CatchSignalEventRequest could run.
Create the directory with mkdir(..., 0755, true) before writing. Uses the
current storage_path(), so tenant and landlord contexts are unchanged.
Related tickets:
https://processmaker.atlassian.net/browse/FOUR-32357
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Fix intermediate signal throw when storage/app/private is missing
ThrowSignalEvent calls packTemporalData() in its constructor; that helper wrote to storage_path('app/private') without ensuring the directory exists. On develop-qa the folder was absent, causing file_put_contents to fail and blocking the signal before CatchSignalEventRequest could run.
Create the directory with mkdir(..., 0755, true) before writing. Uses the current storage_path(), so tenant and landlord contexts are unchanged.
Related tickets:
https://processmaker.atlassian.net/browse/FOUR-32357