Skip to content

FOUR-31727: Fix DevLink bundle listing and selector search#8889

Open
eiresendez wants to merge 3 commits into
developfrom
bugfix/FOUR-31727
Open

FOUR-31727: Fix DevLink bundle listing and selector search#8889
eiresendez wants to merge 3 commits into
developfrom
bugfix/FOUR-31727

Conversation

@eiresendez

@eiresendez eiresendez commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Issue & Reproduction Steps

FOUR-31727 fixes an issue where DevLink bundles outside the first API page were not available from the UI. To reproduce, create more than 15 local bundles, then go to /admin/devlink/local-bundles or open an Add to Bundle modal from a supported asset list. The admin route only displayed the first page of bundles, and the dropdown search could not find bundles that were not already loaded client-side.

Solution

  • Added pagination to the local DevLink bundles admin list.
  • Updated the local bundles admin list to request newest bundles first.
  • Updated the Add to Bundle dropdown to load the latest 100 editable bundles.
  • Added backend search support to the shared backend select used by Add to Bundle.
  • Added API coverage for local bundle pagination, filtering, editable filtering, and explicit newest-first ordering.

How to Test

Automated test run:
vendor/bin/phpunit tests/Feature/Api/DevLinkTest.php --filter LocalBundles

Manual verification:

  1. Create more than 100 local editable bundles.
  2. Open /admin/devlink/local-bundles and confirm bundles are paginated and newest bundles appear first.
  3. Open an Add to Bundle modal and confirm the newest 100 editable bundles are available.
  4. Search for an older bundle in the dropdown and confirm it is found through backend search.

Related Tickets & Packages

ci:deploy

.

@Kookster310

Copy link
Copy Markdown
Contributor

QA server K8S was successfully deployed https://ci-2ba51b845d.engk8s.processmaker.net

@eiresendez eiresendez self-assigned this Jul 1, 2026
@eiresendez
eiresendez requested a review from CarliPinell July 1, 2026 13:45

@CarliPinell CarliPinell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix — pagination, newest-first ordering, and remote search address the reported DevLink bundle listing issue well, and the new API tests give good coverage.

I left two inline notes on BackendSelect.vue around remote-search UX and request ordering. Neither is a merge blocker from my side.

Comment thread resources/js/components/shared/BackendSelect.vue Outdated
Comment thread resources/js/components/shared/BackendSelect.vue

@CarliPinell CarliPinell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor observations. Approved.

@vladyrichter

Copy link
Copy Markdown

QA server K8S was successfully deployed https://ci-2ba51b845d.engk8s.processmaker.net

@processmaker-sonarqube

Copy link
Copy Markdown

@gitguardian

gitguardian Bot commented Jul 23, 2026

Copy link
Copy Markdown

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
34069781 Triggered Generic Password 8b915fa resources/views/auth/passwords/reset.blade.php View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@eiresendez

Copy link
Copy Markdown
Contributor Author

Please disregard the GitGuardian warning, as it is a false positive inherited from develop through the latest merge. The same finding was previously reported in PR #8871 under GitGuardian incident 34069781.

@vladyrichter

Copy link
Copy Markdown

QA server K8S was successfully deployed https://ci-2ba51b845d.engk8s.processmaker.net

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants