FOUR-31727: Fix DevLink bundle listing and selector search#8889
FOUR-31727: Fix DevLink bundle listing and selector search#8889eiresendez wants to merge 3 commits into
Conversation
|
QA server K8S was successfully deployed https://ci-2ba51b845d.engk8s.processmaker.net |
CarliPinell
left a comment
There was a problem hiding this comment.
Thanks for the fix — pagination, newest-first ordering, and remote search address the reported DevLink bundle listing issue well, and the new API tests give good coverage.
I left two inline notes on BackendSelect.vue around remote-search UX and request ordering. Neither is a merge blocker from my side.
CarliPinell
left a comment
There was a problem hiding this comment.
Minor observations. Approved.
|
QA server K8S was successfully deployed https://ci-2ba51b845d.engk8s.processmaker.net |
|
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 34069781 | Triggered | Generic Password | 8b915fa | resources/views/auth/passwords/reset.blade.php | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
|
Please disregard the GitGuardian warning, as it is a false positive inherited from develop through the latest merge. The same finding was previously reported in PR #8871 under GitGuardian incident 34069781. |
|
QA server K8S was successfully deployed https://ci-2ba51b845d.engk8s.processmaker.net |





Issue & Reproduction Steps
FOUR-31727 fixes an issue where DevLink bundles outside the first API page were not available from the UI. To reproduce, create more than 15 local bundles, then go to
/admin/devlink/local-bundlesor open an Add to Bundle modal from a supported asset list. The admin route only displayed the first page of bundles, and the dropdown search could not find bundles that were not already loaded client-side.Solution
How to Test
Automated test run:
vendor/bin/phpunit tests/Feature/Api/DevLinkTest.php --filter LocalBundlesManual verification:
/admin/devlink/local-bundlesand confirm bundles are paginated and newest bundles appear first.Related Tickets & Packages
ci:deploy
.