fix(e2e): prevent wildcard route from intercepting sync endpoint - #3491
Open
TanCodeX wants to merge 1 commit into
Open
fix(e2e): prevent wildcard route from intercepting sync endpoint#3491TanCodeX wants to merge 1 commit into
TanCodeX wants to merge 1 commit into
Conversation
|
Thanks for your first PR on DevTrack! 🎉 A maintainer will review it within 48 hours. While you wait:
If you find DevTrack useful, a ⭐ star on the repo is always appreciated — it helps the project grow and attract more contributors! |
GSSoC Label Checklist 🏷️@Priyanshu-byte-coder — please apply the appropriate labels before merging: Difficulty (pick one):
Quality (optional):
Validation (required to score):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #3309
Type of Change
What Changed
e2e/goals.spec.tsto use a regular expression with a negative lookahead./api/goals/syncfrom the catch-all/api/goals/**route so the dedicated sync mock can handle the request.204fallback response.How to Test
npx playwright test e2e/goals.spec.ts./api/goals/syncis handled by its dedicated mock.Expected result:
All 4 goals E2E tests pass successfully, including
[Goals E2E] deleting a goal removes it from the list.Screenshots / Recordings
Checklist
console.log, debug code, or commented-out blocksnpm run lintpasses locallynpm run type-check)Accessibility (UI changes only)
Additional Context
The catch-all route
**/api/goals/**was aggressively interceptingPOST /api/goals/syncduring the goal deletion flow.The route was changed from: