fix(coding-agent): stabilize macOS process identity - #908
Open
chai1any wants to merge 1 commit into
Open
Conversation
Run the portable ps start-time query under a fixed timezone and locale so a system timezone change does not invalidate daemon ownership metadata.\n\nFixes PrimeIntellect-ai#879
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ps -o lstart=process identity query withTZ=UTCandLC_ALL=CVerification
npx tsx ../../node_modules/vitest/dist/cli.js --run test/daemon-ps.test.ts(24 tests passed)npm run checkprocess.env.TZbetweenAmerica/Los_AngelesandAsia/Kolkata; both IDs were identicalFixes #879
Note
Fix macOS process identity invalidation caused by timezone changes
getProcessStartIdin session-lease.ts usespsto derive a stable process start identifier, but the output varies with system timezone or locale, causing the running daemon's identity to change.pscall into a newgetPsProcessStartIdhelper that forcesTZ=UTCandLC_ALL=Cin the subprocess environment, ensuring a consistent output regardless of system settings.runProcessQueryto accept an optionalenvoverride so callers can supply a custom environment without affecting the default behavior.Macroscope summarized 7053d4f.