Skip to content

Fix the wishlist products sort dropdown under Bootstrap 5 themes - #501

Open
boo-code wants to merge 3 commits into
PrestaShop:devfrom
boo-code:fix/wishlist-sort-dropdown-bootstrap5
Open

Fix the wishlist products sort dropdown under Bootstrap 5 themes#501
boo-code wants to merge 3 commits into
PrestaShop:devfrom
boo-code:fix/wishlist-sort-dropdown-bootstrap5

Conversation

@boo-code

@boo-code boo-code commented Jul 7, 2026

Copy link
Copy Markdown
Questions Answers
Branch? dev
Description? On the wishlist "products list" page the sort dropdown does not open — clicking it does nothing. The toggle button in ProductsListContainer.vue uses the Bootstrap 4 attribute data-toggle="dropdown". PrestaShop 9's default theme (Hummingbird) ships Bootstrap 5, which only recognises data-bs-toggle, so its dropdown plugin never binds to the button and the .dropdown-menu is never shown. This renames the attribute to data-bs-toggle="dropdown"; the rest of the markup (.dropdown, .dropdown-menu, aria-*) is already Bootstrap 5 compatible. The public/productslist.bundle.js is updated to match the source (the same single-attribute change the production build produces).
Type? bug fix
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #509
Sponsor company
How to test? With the Hummingbird theme (Bootstrap 5), add products to a wishlist, open the wishlist products list, and click the sort dropdown. Before: nothing happens. After: the dropdown opens and the sort options (Last added, price, etc.) are selectable. Root cause confirmed in the shipped bundle ("data-toggle":"dropdown" -> Bootstrap 5 ignores it); the fix makes the button carry data-bs-toggle so Bootstrap 5's dropdown plugin toggles the menu.

@ps-jarvis

Copy link
Copy Markdown

Hello @boo-code!

This is your first pull request on blockwishlist repository of the PrestaShop project.

Thank you, and welcome to this Open Source community!

@SharakPL SharakPL left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect this change would in turn make Classic and all BS4 themes out there incompatible with the module so a different solution is needed here.

I haven't tested it yet but having both attributes should make it work with BS4 and BS5 themes...

@ps-jarvis ps-jarvis moved this from Ready for review to Waiting for author in PR Dashboard Jul 19, 2026
@boo-code

Copy link
Copy Markdown
Author

Good point — kept both attributes now: data-toggle="dropdown" for Bootstrap 4 themes (Classic) and data-bs-toggle="dropdown" for Bootstrap 5 (Hummingbird). Each Bootstrap version only reads its own attribute, so both themes bind the dropdown and neither is affected by the extra attribute. Bundle rebuilt from the same source in 9ae4315.

@SharakPL SharakPL added Waiting for QA Status: Action required, Waiting for test feedback and removed Waiting for author labels Jul 20, 2026
@ps-jarvis ps-jarvis moved this from Waiting for author to To be tested in PR Dashboard Jul 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Waiting for QA Status: Action required, Waiting for test feedback

Projects

Status: To be tested

Development

Successfully merging this pull request may close these issues.

Can't change wishlist content order with Hummingbird theme

3 participants