Enforce corporate_id claim in Twenty SSO proxy-login and JWT guard#19
Open
UsamaSadiq wants to merge 1 commit into
Open
Enforce corporate_id claim in Twenty SSO proxy-login and JWT guard#19UsamaSadiq wants to merge 1 commit into
UsamaSadiq wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add corporate_id enforcement to Twenty's SSO auth flow. When
SMB_CORPORATE_IDis set, both the proxy-login controller and the JWT auth guard decode theX-Auth-Request-Access-Tokenheader and reject requests wherecustom:is_corporateis not"true"orcustom:corporate_iddoes not match. Returns 403 on mismatch. When the env var is empty, all checks are skipped (backward compatible).Changes:
sso-proxy-login.controller.ts: newcheckCorporateId()method, called after email resolution before user provisioningjwt-auth.guard.ts: newcheckCorporateId()method, called after proxy identity check on every authenticated requestconfig-variables.ts: registerSMB_CORPORATE_IDconfig variableThis is the per-app Layer 2 enforcement that closes the Bearer token bypass path (
SKIP_JWT_BEARER_TOKENS=truein oauth2-proxy). Layer 1 enforcement in mpass-auth-proxy is in foss-server-bundle PR twentyhq#116.Testing
SMB_CORPORATE_IDskips all checkscustom:is_corporate)